844831 - XML Parsing Error: undefined entity &charsetMenuUnicode.accesskey;

Status: RESOLVED WONTFIX

(Firefox :: Extension Compatibility, defect)

Description

[Tyler]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Build ID: 20130220104816

Steps to reproduce:

Any extensions that use this, fails.


Actual results:

Click on an element that uses the parser, and an error will appear.

i.e.

XML Parsing Error: undefined entity
Location: chrome://fireftp/content/accountManager.xul
Line Number 267, Column 17:                <menu label="&charsetMenuUnicode.label;" accesskey="&charsetMenuUnicode.accesskey;" datasources="rdf:charset-menu" ref="NC:BrowserUnicodeCharsetMenuRoot">
----------------^


Expected results:

Should have worked :P

Comment 1

[[:Aleksej]]

See also bug 802725.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Why is this an XML bug?

The extension is trying to use the charsetMenuUnicode.accesskey entity, which doesn't exist.  So the above is not well-formed XML.

The entity was removed in bug 805374 because it was no longer used; extensions shouldn't be reusing core definitions like this for their own purposes....

As far as I can tell, this just needs to be fixed in the fireftp extension.

Comment 3

[Henri Sivonen (:hsivonen)]

This went unfixed for long enough that the extensions have probably taken action by now anyway. Moreover, the menu is undergoing even more changes, so add-ons that expect .dtd stability are going to break anyway. Add-ons really should not be depending in Firefox's .dtd files like this.