Closed Bug 844984 Opened 8 years ago Closed 8 years ago

[Overdraw] Awesomebar is in red

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 22

People

(Reporter: sriram, Assigned: sriram)

Details

Attachments

(1 file)

Awesomebar has so much overdraw making it go to red. Removing overdraw could result in faster scrolling of awesomescreen lists!
Attached patch PatchSplinter Review
This does few things to make awesomebar go from http://cl.ly/image/1b0A3x2W1e0W to http://cl.ly/image/2w1K3X0J3S3L
1. Reset window background.
2. Make the entire layout's background to be transparent (Screen.Transparent)
3. Restrict the blue background behind the tabs-widget container, just to the height of the tabs-widget, instead of the entire app.
Attachment #718011 - Flags: review?(bnicholson)
Comment on attachment 718011 [details] [diff] [review]
Patch

Review of attachment 718011 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/AwesomeBar.java
@@ +277,5 @@
>  
>          if (!hasFocus)
>              return;
>  
> +        getWindow().setBackgroundDrawable(null);

Is this needed? Can you just do this in the XML?
Attachment #718011 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/29de190ac31c
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.