Open Bug 845100 Opened 13 years ago Updated 4 years ago

Need tests to capture when we change the User Agent (UA) String

Categories

(Core :: Networking, defect, P5)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

People

(Reporter: cmtalbert, Unassigned)

Details

(Whiteboard: [necko-would-take])

It turns out from a pretty cursory review of the tests that we don't have tests that can capture when we change the UA string. The UA string seems to be built by the network code here: http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpHandler.cpp#616 So I believe I'm filing this in the correct area. If I'm not, please correct it. So, I think we need to write a few tests to ensure that we have the proper UA string for each platform. We could probably get by with a couple of xpcshell tests.
The initial driver for my question about UA tests was bug 839065. With the exception of version numbers, our mobile UAs are static. We should guard against their inadvertent modification.
This is a good idea. :-) Gerv
Whiteboard: [necko-would-take]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5

Resolving as fixed because I added UA string tests in bug 1679929:

https://hg.mozilla.org/integration/autoland/rev/5415efb793f4

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.