Closed
Bug 845117
Opened 12 years ago
Closed 12 years ago
Mark js/ipc as FAIL_ON_WARNINGS
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
644 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
With bug 845021 fixed, /js/ipc is now warning-free.
Filing this bug on marking it as such.
Green try run: https://tbpl.mozilla.org/?tree=Try&rev=0eb6c49574ba
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #718155 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Note that is fairly limited in scope -- it only affects these 2 files:
> 28 CPPSRCS = \
> 29 ObjectWrapperParent.cpp \
> 30 ObjectWrapperChild.cpp \
> 31 $(NULL)
reference: https://mxr.mozilla.org/mozilla-central/source/js/ipc/Makefile.in#28
|
||
Updated•12 years ago
|
Attachment #718155 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Inbound's closed at the moment, so marking checkin-needed to be sure that someone else lands this in case I forget about it. :)
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•