845211 - [Wi-Fi] "undefined" sometimes showed to Wi-Fi MAC address value of Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[leo.bugzilla.gecko]

"undefined" sometimes showed to Wi-Fi MAC address of Settings after the following reproduce sequence.

1. Wi-Fi disable
2. Phone Power off and on
3. Wi-Fi enable in the Settings > Wi-Fi pannel
4. check Wi-Fi MAC address in the Settings > Wi-Fi > Manage networks

I think DOMWifiManager.js should update mac address value after Wi-Fi is enabled.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

fwiw, the bug here is that if a DOMWifiManager is created and wifi is disabled (and was never enabled since startup) we never update its mac address when wifi is turned on. We can probably just send the mac address in the wifiUp message manager message.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Wi-Fi setting does not contain the Mac Address.  It contains the IP address, and the IP address will be undefined if it doesn't get an IP Address from the DHCP server.

The Mac Address is located in the Device information -> More Information section.  This bug is invalid.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Naoki, can you please try the steps in comment 0 but check for the mac address in the proper place? Turning on wifi should update the MAC address in the existing settings instance. Right now, you have to close settings and restart it before you see the mac address.

Comment 4

[Alex Keybl [:akeybl]]

Tracking (assuming this is reproducible) but not blocking, given minimal user impact.

Comment 5

[Vincent Chang[:vchang][changyihsin]]

Attachment: Possible fix, patch v1.0

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 725451 [details] [diff] [review]
Possible fix, patch v1.0

My only thought is that it might be worth it to store the mac address somewhere after the first time we get it and avoid calling getMacAddress every time we restart wifi. It probably isn't worth it, though. r=me either way.

Comment 7

[Vincent Chang[:vchang][changyihsin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fbbb2fc5dbb

Comment 8

[Vincent Chang[:vchang][changyihsin]]

I received a Regression e-mail after push the patch to inbound. Should I do something about it ? 

Regression: Mozilla-Inbound-Non-PGO - Dromaeo (DOM) - XP - 2.97% decrease
-------------------------------------------------------------------------
    Previous: avg 380.366 stddev 4.082 of 30 runs up to revision 4f9a36fafdfd
    New     : avg 369.083 stddev 2.172 of 5 runs since revision 9fbbb2fc5dbb
    Change  : -11.283 (2.97% / z=2.764)
    Graph   : http://mzl.la/Y9BM6A

Changeset range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4f9a36fafdfd&tochange=9fbbb2fc5dbb

Changesets:
  * http://hg.mozilla.org/integration/mozilla-inbound/rev/9fbbb2fc5dbb
    : Vincent Chang <[e-mail]> - Bug 845211 - [Wi-Fi] "undefined" sometimes showed to Wi-Fi MAC address value of Settings. r=mrbkap
    : http://bugzilla.mozilla.org/show_bug.cgi?id=845211

Comment 9

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/9fbbb2fc5dbb

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Should the wifiManager.macAddress return the string "undefined", instead of undefined (the obj), when the macAddress is not available?

This is exactly what I get at https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/connectivity.js#L115 while debugging the STR for bug 880617, which breaks checks like "(wifiManager.macAddress != undefined)".

Comment 11

[Vincent Chang[:vchang][changyihsin]]

(In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] (AFK until June 22) from comment #10)
> Should the wifiManager.macAddress return the string "undefined", instead of
> undefined (the obj), when the macAddress is not available?
> 
> This is exactly what I get at
> https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/
> connectivity.js#L115 while debugging the STR for bug 880617, which breaks
> checks like "(wifiManager.macAddress != undefined)".

I think you can use "if (!wifiManager.macAddress)" to check it, right ?

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Vincent Chang[:vchang] from comment #11)
> (In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] (AFK until June 22) from
> comment #10)
> > Should the wifiManager.macAddress return the string "undefined", instead of
> > undefined (the obj), when the macAddress is not available?
> > 
> > This is exactly what I get at
> > https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/
> > connectivity.js#L115 while debugging the STR for bug 880617, which breaks
> > checks like "(wifiManager.macAddress != undefined)".
> 
> I think you can use "if (!wifiManager.macAddress)" to check it, right ?

That would not work to check if wifiManager.macAddress is undefined since !"undefined" is false. I think that macAddress is not set properly when it's not available and ends up being a string with the value "undefined".

Comment 13

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] from comment #12)
> That would not work to check if wifiManager.macAddress is undefined since
> !"undefined" is false. I think that macAddress is not set properly when it's
> not available and ends up being a string with the value "undefined".

wifiManager.macAddress should definitely be the value undefined, not the string "undefined". Can you file that bug? It should (hopefully) be a simple fix.

Comment 14

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Filed bug 888227 to highlight this issue.