845437 - Get rid of the aImmediateRedraw argument from nsSliderFrame methods

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jonathan Watt [:jwatt]]

The aImmediateRedraw argument that various nsSliderFrame methods have can die since it isn't actually doing anything.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

From some hg archeology, it looks like we dropped the last usage of a variable w/ this name in nsSliderFrame was removed here:
  https://hg.mozilla.org/mozilla-central/rev/e5651c513f3f#l73.12

Adding dependency on that cset's bug, bug 539356 (DLBI).

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 718511 [details] [diff] [review]
patch

Looks good.

(I slightly wonder whether this is a case where we *should* be using this variable somehow, but it looks like it's no longer needed because we switched from explicitly invalidating (with flags about how we want to be invalidated) to letting DLBI manage that for us.  And I suppose we can trust that DLBI knows what it's doing.)

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27c71bbc1675

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/27c71bbc1675