84548 - WWW_Activate DDE request doesn't work

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[aaronr]

I have a DDE application that is based off of the Netscape DDE test app 
that can be obtained from developer.netscape.com.  It has been modified 
to enable testing Netscape 6, Mozilla and communicator.  I tried it 
using the latest trunk build after the fix for 25699 went in.  I 
verified that WWW_OpenURL works for both the  Request and Execute 
transaction types.  But when I tried the WWW_Activate, it didn't work.  
It looks like the code for the case  topicActivate tests for the string 
"-1" instead of the value -1.  If testing for a string, you should test 
for "4294967295" (the decimal equivalent to 0xFFFFFFFF).  When 
generating the -1, my test program (and I guess others) use the 
following "sprintf( caString, "%lu", *pWord )" (where *pWord is 
0xFFFFFFFF) and passes the resultant onto the DdeCreateStringHandle.  
When I change the code to look for "4294967295", the rest of teh 
activate code works fine.

I don't know if looking solely for "4294967295" is the only solution, 
but it needs to be in the list of things to check for.

--Aaron

Comment 1

[Bill Law]

I looked at the Communicator code that parses the arguments and it uses strtoul
and then compares the resulting unsigned long to 0xFFFFFFFF.  We should do
likewise, I guess.

The whole thing is pretty ill-defined but I suppose we should support our own
test application.

Comment 2

[Edward Kandrot]

Sorry, I do not know anything about this.  Looking through lxr.mozilla.org for
some of the keywords you mentioned, it appears that they all exist in xpfe (not
xpcom).  I am reassigning to law.

Comment 3

[aaronr]

Attachment: fix for bug 84548

Comment 4

[Bill Law]

Thanks Aaron.  r=law

I'll ask blake to super-review and then you can check it in, pending all the
other  hoop-jumping-through that might currently apply.

Comment 5

[Blake Ross]

sr=blake

Comment 6

[Mike Kaply [:mkaply]]

This got overlooked for checkin. My apologies.

Bill - you might want this on nsbranch.

I'll get the approvals to put it on the 0.9.5 branch

Comment 7

[Mike Kaply [:mkaply]]

Fix checked in.

I'm not going to worry about 0.9.5.

This probably should go in nsbranch though.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I tryed WWW_Activate topic with 0xFFFFFFFF on 2002050304/windows2000.
But WWW_Activate DDE request doesn't work this case.

IE and Netscape4.x work WWW_Activate with "0xFFFFFFFF".
I looded mozilla source.
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsNativeAppSupportWin.cpp#1363

1363 if ( windowID.Equals( "-1" ) ||
1364     windowID.Equals( "4294967295" ) ) {

This source means "4294967295" not equal "0xFFFFFFFF".
I think that I should perform it as follows.

1363 if ( windowID.Equals( "-1" ) ||
1364     windowID.Equals( "4294967295" ) ||
         windowID.Equals( "0xFFFFFFFF" ) ) {

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'll file a new bug for left works.