845499 - Nightly UI on Ouya looks wrong

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot

See attached screenshot. That's the latest nightly running on the Ouya.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This appears to be happening because in resources/layout-large-v11/browser_toolbar_menu.xml.in, the Gecko.ImageButton with +id/menu has an android:visibility="gone" and so it gets laid out at 0,0 with size 0x0. Then the menu_items LinearLayout which is supposed to be to the left of that gets positioned wrongly, and the RelativeLayout that contains the awesome_bar is also positioned wrongly. Making the menu visibility "visible" fixes the problem but of course also makes the menu button appear on the toolbar.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Fix sIsSmallTablet cache

Something I found while poking around.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Fix for ouya (or tablets with hardware menu button)

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 723451 [details] [diff] [review]
Fix sIsSmallTablet cache

:D :D

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 723452 [details] [diff] [review]
Fix for ouya (or tablets with hardware menu button)

Looks good to me.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2472ca0933cd
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa003f7e016e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2472ca0933cd
https://hg.mozilla.org/mozilla-central/rev/fa003f7e016e