845527 - Replace nsMemoryReporterManager's nsCOMArray::Count() usages with Length()

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Daniel Holbert [:dholbert]]

We currently spam these build warnings:
{
xpcom/base/nsMemoryReporterManager.cpp: In member function ‘virtual nsresult {anonymous}::HashtableEnumerator::HasMoreElements(bool*)’:
xpcom/base/nsMemoryReporterManager.cpp:803:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

xpcom/base/nsMemoryReporterManager.cpp: In member function ‘virtual nsresult {anonymous}::HashtableEnumerator::GetNext(nsISupports**)’:
xpcom/base/nsMemoryReporterManager.cpp:809:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

for comparisons between an unsigned index and nsCOMArray::Count() in nsMemoryReporterManager.cpp.

I think we should just replace (all?) usages of Count() in that file with Length(). (which was recently added to nsCOMArray, for convenience)

Comment 1

[Daniel Holbert [:dholbert]]

Oh, looks like those are the only two usages of Count() in that file anyway. (For some reason I thought I saw others)

So, this is easy.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1: s/Count()/Length()/

(This patch also adds a newline between NS_IMETHODIMP and the function-signature, for consistency with the rest of the impls in this file & with prevailing mozilla style.)

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/592eb93c5d73

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/592eb93c5d73