Closed
Bug 845569
Opened 12 years ago
Closed 12 years ago
Land tests for various bugs
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
mozilla22
People
(Reporter: gkw, Assigned: gkw)
Details
Attachments
(1 file, 1 obsolete file)
1.33 KB,
patch
|
gkw
:
review+
|
Details | Diff | Splinter Review |
I'll be attaching a patch to land testcases for bug 831424 (2 testcases), bug 836601 and bug 839758.
![]() |
Assignee | |
Comment 1•12 years ago
|
||
$ python -u jit_test.py --no-slow --tbpl -t 1200 <js shell> bug836601.js bug839758.js bug831424-1.js bug831424-2.js
[40| 0| 0| 0] 100% ==================================================>| 20.4s
PASSED ALL
bug831424-2.js seemed slightly slower than the rest but it does not seem to be much of a problem, I guess?
Attachment #718707 -
Flags: review?(terrence)
![]() |
Assignee | |
Updated•12 years ago
|
Assignee: general → gary
Status: NEW → ASSIGNED
Comment 2•12 years ago
|
||
Comment on attachment 718707 [details] [diff] [review]
patch v1
Review of attachment 718707 [details] [diff] [review]:
-----------------------------------------------------------------
Seems reasonable.
Attachment #718707 -
Flags: review?(terrence) → review+
![]() |
Assignee | |
Comment 3•12 years ago
|
||
Flags: in-testsuite+
Comment 4•12 years ago
|
||
Backed out for bug839758.js assertions:
https://tbpl.mozilla.org/php/getParsedLog.php?id=20133306&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20134585&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20135134&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20135761&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20135881&tree=Mozilla-Inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/622278b04c18
![]() |
Assignee | |
Comment 5•12 years ago
|
||
I've removed the testcase for bug 839758, reopened it, brought forward r+ in this patch, and will reland this.
Attachment #718707 -
Attachment is obsolete: true
Attachment #719094 -
Flags: review+
![]() |
Assignee | |
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
![]() |
Assignee | |
Comment 8•12 years ago
|
||
VERIFIED because this is in-testsuite+.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•