845569 - Land tests for various bugs

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I'll be attaching a patch to land testcases for bug 831424 (2 testcases), bug 836601 and bug 839758.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v1

$ python -u jit_test.py --no-slow --tbpl -t 1200 <js shell> bug836601.js bug839758.js bug831424-1.js bug831424-2.js
[40| 0| 0| 0] 100% ==================================================>|  20.4s
PASSED ALL

bug831424-2.js seemed slightly slower than the rest but it does not seem to be much of a problem, I guess?

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 718707 [details] [diff] [review]
patch v1

Review of attachment 718707 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9d90bf85bcf

Comment 4

[Ed Morley [:emorley]]

Backed out for bug839758.js assertions:
https://tbpl.mozilla.org/php/getParsedLog.php?id=20133306&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20134585&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20135134&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20135761&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20135881&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/622278b04c18

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v2

I've removed the testcase for bug 839758, reopened it, brought forward r+ in this patch, and will reland this.

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e85c2b64d0ed

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e85c2b64d0ed

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

VERIFIED because this is in-testsuite+.