Closed Bug 845613 Opened 7 years ago Closed 7 years ago

Locking issues in the write poisoning code

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: espindola, Assigned: espindola)

References

Details

Attachments

(1 file, 2 obsolete files)

I found 3 issues while working on 845098:

* Using a local static in getDebugFDsLock, which is not safe on windows.
* Lock not held while deleting the std::vector with debug fds
* We have a copy in mozPoisonWriteMac.cpp :-(
Attached patch patch (obsolete) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=09b3bb25a6f9
Attachment #718772 - Attachment is obsolete: true
Attachment #718772 - Flags: review?(bgirard)
Attachment #719043 - Flags: review?(bgirard)
Attachment #719101 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/8db79d56a4b1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.