845613 - Locking issues in the write poisoning code

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

I found 3 issues while working on 845098:

* Using a local static in getDebugFDsLock, which is not safe on windows.
* Lock not held while deleting the std::vector with debug fds
* We have a copy in mozPoisonWriteMac.cpp :-(

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=fc4a675d3972

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=09b3bb25a6f9

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Keep the static but add comments

https://tbpl.mozilla.org/?tree=Try&rev=9782e2bb9cac

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8db79d56a4b1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8db79d56a4b1