Closed
Bug 845631
Opened 12 years ago
Closed 12 years ago
Remove nsXMLHttpProgressEvent
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(3 files, 1 obsolete file)
|
27.11 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
|
26.20 KB,
patch
|
Details | Diff | Splinter Review | |
|
26.61 KB,
patch
|
Details | Diff | Splinter Review |
We should just use plain normal progress events.
Patch coming tomorrow (UOT).
|
||
Comment 1•12 years ago
|
||
Will LSProgressEvent be gone?
|
Assignee | |
Comment 2•12 years ago
|
||
Yes.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #718963 -
Flags: review?(Ms2ger)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 718963 [details] [diff] [review]
patch
Review of attachment 718963 [details] [diff] [review]:
-----------------------------------------------------------------
You need to remove the strings from dom/locales/en-US/chrome/dom/dom.properties too.
I'd appreciate it if you waited to land until bug 784841 merges; that should be later this week.
::: dom/base/nsDOMClassInfo.cpp
@@ -201,5 @@
> #include "nsIDOMHTMLObjectElement.h"
> #include "nsIDOMTimeRanges.h"
> #include "nsIDOMHTMLVideoElement.h"
> #include "nsIDOMHTMLAudioElement.h"
> -#include "nsIDOMProgressEvent.h"
(Is ProgressEvent auto-generated?)
Attachment #718963 -
Flags: superreview?(jonas)
Attachment #718963 -
Flags: review?(Ms2ger)
Attachment #718963 -
Flags: review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
(In reply to :Ms2ger from comment #4)
> I'd appreciate it if you waited to land until bug 784841 merges; that should
> be later this week.
k
> > -#include "nsIDOMProgressEvent.h"
>
> (Is ProgressEvent auto-generated?)
Yes.
|
|
Assignee | |
Comment 6•12 years ago
|
||
Attachment #718963 -
Attachment is obsolete: true
Attachment #718963 -
Flags: superreview?(jonas)
Attachment #719021 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 7•12 years ago
|
||
(In reply to :Ms2ger from comment #4)
> I'd appreciate it if you waited to land until bug 784841 merges; that should
> be later this week.
I guess I can wait a day or two.
Comment on attachment 719021 [details] [diff] [review]
patch
Review of attachment 719021 [details] [diff] [review]:
-----------------------------------------------------------------
Yes!
Attachment #719021 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 9•12 years ago
|
||
Maybe this compiles with the latest build system changes
|
|
||
Comment 10•12 years ago
|
||
Don't forget to remove dom/interfaces/load-save/moz.build too.
|
|
Assignee | |
Comment 11•12 years ago
|
||
|
|
Assignee | |
Comment 12•12 years ago
|
||
|
||
Comment 13•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Comment 14•12 years ago
|
||
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22
Keywords: dev-doc-complete,
site-compat
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•