The default bug view has changed. See this FAQ.

Remove nsXMLHttpProgressEvent

RESOLVED FIXED in mozilla22

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla22
x86_64
Linux
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
We should just use plain normal progress events.
Patch coming tomorrow (UOT).
Will LSProgressEvent be gone?

Updated

4 years ago
Blocks: 277662
(Assignee)

Comment 2

4 years ago
Yes.
(Assignee)

Comment 3

4 years ago
Created attachment 718963 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=580c551a2b87
Attachment #718963 - Flags: review?(Ms2ger)
Comment on attachment 718963 [details] [diff] [review]
patch

Review of attachment 718963 [details] [diff] [review]:
-----------------------------------------------------------------

You need to remove the strings from dom/locales/en-US/chrome/dom/dom.properties too.

I'd appreciate it if you waited to land until bug 784841 merges; that should be later this week.

::: dom/base/nsDOMClassInfo.cpp
@@ -201,5 @@
>  #include "nsIDOMHTMLObjectElement.h"
>  #include "nsIDOMTimeRanges.h"
>  #include "nsIDOMHTMLVideoElement.h"
>  #include "nsIDOMHTMLAudioElement.h"
> -#include "nsIDOMProgressEvent.h"

(Is ProgressEvent auto-generated?)
Attachment #718963 - Flags: superreview?(jonas)
Attachment #718963 - Flags: review?(Ms2ger)
Attachment #718963 - Flags: review+
(Assignee)

Comment 5

4 years ago
(In reply to :Ms2ger from comment #4) 
> I'd appreciate it if you waited to land until bug 784841 merges; that should
> be later this week.

k


> > -#include "nsIDOMProgressEvent.h"
> 
> (Is ProgressEvent auto-generated?)
Yes.
(Assignee)

Comment 6

4 years ago
Created attachment 719021 [details] [diff] [review]
patch
Attachment #718963 - Attachment is obsolete: true
Attachment #718963 - Flags: superreview?(jonas)
Attachment #719021 - Flags: review?(jonas)
(Assignee)

Comment 7

4 years ago
(In reply to :Ms2ger from comment #4) 
> I'd appreciate it if you waited to land until bug 784841 merges; that should
> be later this week.
I guess I can wait a day or two.
(Assignee)

Updated

4 years ago
Blocks: 822399
Comment on attachment 719021 [details] [diff] [review]
patch

Review of attachment 719021 [details] [diff] [review]:
-----------------------------------------------------------------

Yes!
Attachment #719021 - Flags: review?(jonas) → review+
(Assignee)

Comment 9

4 years ago
Created attachment 719576 [details] [diff] [review]
v3

Maybe this compiles with the latest build system changes
Don't forget to remove dom/interfaces/load-save/moz.build too.
(Assignee)

Comment 11

4 years ago
Created attachment 719586 [details] [diff] [review]
v4
(Assignee)

Comment 12

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cde774aa665
https://hg.mozilla.org/mozilla-central/rev/7cde774aa665
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22
Keywords: dev-doc-complete, site-compat
You need to log in before you can comment on or make changes to this bug.