Last Comment Bug 845631 - Remove nsXMLHttpProgressEvent
: Remove nsXMLHttpProgressEvent
Status: RESOLVED FIXED
: dev-doc-complete, site-compat
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla22
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks: 277662 822399
  Show dependency treegraph
 
Reported: 2013-02-26 18:28 PST by Olli Pettay [:smaug]
Modified: 2013-05-16 11:54 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (25.06 KB, patch)
2013-02-27 05:52 PST, Olli Pettay [:smaug]
Ms2ger: review+
Details | Diff | Splinter Review
patch (27.11 KB, patch)
2013-02-27 08:02 PST, Olli Pettay [:smaug]
jonas: review+
Details | Diff | Splinter Review
v3 (26.20 KB, patch)
2013-02-28 10:38 PST, Olli Pettay [:smaug]
no flags Details | Diff | Splinter Review
v4 (26.61 KB, patch)
2013-02-28 10:53 PST, Olli Pettay [:smaug]
no flags Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2013-02-26 18:28:29 PST
We should just use plain normal progress events.
Patch coming tomorrow (UOT).
Comment 1 Masatoshi Kimura [:emk] 2013-02-26 19:52:44 PST
Will LSProgressEvent be gone?
Comment 2 Olli Pettay [:smaug] 2013-02-27 04:20:48 PST
Yes.
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2013-02-27 07:43:24 PST
Comment on attachment 718963 [details] [diff] [review]
patch

Review of attachment 718963 [details] [diff] [review]:
-----------------------------------------------------------------

You need to remove the strings from dom/locales/en-US/chrome/dom/dom.properties too.

I'd appreciate it if you waited to land until bug 784841 merges; that should be later this week.

::: dom/base/nsDOMClassInfo.cpp
@@ -201,5 @@
>  #include "nsIDOMHTMLObjectElement.h"
>  #include "nsIDOMTimeRanges.h"
>  #include "nsIDOMHTMLVideoElement.h"
>  #include "nsIDOMHTMLAudioElement.h"
> -#include "nsIDOMProgressEvent.h"

(Is ProgressEvent auto-generated?)
Comment 5 Olli Pettay [:smaug] 2013-02-27 07:58:36 PST
(In reply to :Ms2ger from comment #4) 
> I'd appreciate it if you waited to land until bug 784841 merges; that should
> be later this week.

k


> > -#include "nsIDOMProgressEvent.h"
> 
> (Is ProgressEvent auto-generated?)
Yes.
Comment 6 Olli Pettay [:smaug] 2013-02-27 08:02:02 PST
Created attachment 719021 [details] [diff] [review]
patch
Comment 7 Olli Pettay [:smaug] 2013-02-27 08:03:17 PST
(In reply to :Ms2ger from comment #4) 
> I'd appreciate it if you waited to land until bug 784841 merges; that should
> be later this week.
I guess I can wait a day or two.
Comment 8 Jonas Sicking (:sicking) PTO Until July 5th 2013-02-27 14:33:53 PST
Comment on attachment 719021 [details] [diff] [review]
patch

Review of attachment 719021 [details] [diff] [review]:
-----------------------------------------------------------------

Yes!
Comment 9 Olli Pettay [:smaug] 2013-02-28 10:38:12 PST
Created attachment 719576 [details] [diff] [review]
v3

Maybe this compiles with the latest build system changes
Comment 10 :Ms2ger (⌚ UTC+1/+2) 2013-02-28 10:49:28 PST
Don't forget to remove dom/interfaces/load-save/moz.build too.
Comment 11 Olli Pettay [:smaug] 2013-02-28 10:53:24 PST
Created attachment 719586 [details] [diff] [review]
v4
Comment 13 Ryan VanderMeulen [:RyanVM] 2013-02-28 19:44:56 PST
https://hg.mozilla.org/mozilla-central/rev/7cde774aa665
Comment 14 Kohei Yoshino [:kohei] 2013-05-16 11:54:38 PDT
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22

Note You need to log in before you can comment on or make changes to this bug.