845750 - GCLI strings jsbBraceStyleDesc2 and jsbBraceStyleManual2 need descriptive comments

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

jsbBraceStyleManual2=Select the coding style of braces: collapse - put braces on the same line as control statements; expand - put braces on own line (Allman / ANSI style); end-expand - put end braces on own line; expand-strict - put braces on own line even if it will break your code.

1) My understanding is that collapse, end-expand, etc. should not be translated, since they're parameter values. Am I right? In this case a localization comment should be added to explain it.

2) "even if it will break your code". Breaking the code means that the code is no more functional or something else?

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Improved comment

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #0)
> jsbBraceStyleManual2=Select the coding style of braces: collapse - put
> braces on the same line as control statements; expand - put braces on own
> line (Allman / ANSI style); end-expand - put end braces on own line;
> expand-strict - put braces on own line even if it will break your code.
> 
> 1) My understanding is that collapse, end-expand, etc. should not be
> translated, since they're parameter values. Am I right? In this case a
> localization comment should be added to explain it.
> 

Correct, I have added a comment to clarify this.

> 2) "even if it will break your code". Breaking the code means that the code
> is no more functional or something else?

It may no longer be functional. I have added a comment to clarify this.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/8ecc6063cbd7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ecc6063cbd7