845752 - Profiler leaks when opened and closed quickly.

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Girish Sharma [:Optimizer]]

This might be due to remote connection, or simply a profiler related issue, so CC'ed both Panos and Anton.

See https://bugzilla.mozilla.org/show_bug.cgi?id=838069#c13 for more information on how to reproduce. Bug 838069 will disable the test of opening the profiler via the shortcut key in the test "devtools/framework/test/browser_toolbox_window_shortcuts.js". Please re-enable that test when this leak is fixed.

Thanks.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I can't reproduce this locally. Is it still an issue for you?

Comment 2

[Girish Sharma [:Optimizer]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #1)
> I can't reproduce this locally. Is it still an issue for you?

I actually can't pin point this to Profiler. May be its profiler, or debugger or webconsole.

But I sure can tell you a way to reproduce the leak. Just try to run the test browser_toolbox_window_shortcuts.js with this [0] check removed on Windows XP or Mac OSX 10.6

The test opens all tools side by side.

If you cannot find the leak, then it might have gotten fixed by some other bug :)

[0] http://mxr.mozilla.org/mozilla-central/source/browser/devtools/framework/test/browser_toolbox_window_shortcuts.js#21

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I am using a debug build at the moment so I will take a look.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Mike, any luck with this?

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #4)
> Mike, any luck with this?

Oops, I thought I had unassigned myself. Last I tried I couldn't reproduce the issue.

Comment 6

[Anton Kovalyov (:anton)]

Closing, since nobody can reproduce the issue. Re-open if you can.

Comment 7

[Girish Sharma [:Optimizer]]

Its more like nobody has tried to reproduce. I will reenable jsprofiler that was disabled in bug 838069 and pass it through try to see if it is actually fixed or not.

Comment 8

[Anton Kovalyov (:anton)]

Both Michael and myself couldn't reproduce. Anyway, removing it from the Profiler since you couldn't pinpoint to the Profiler in comment #2.

Comment 9

[Girish Sharma [:Optimizer]]

Then let's enable profiler in the shortcuts test and land it. If there are no leaks on inbound, then that will confirm that profiler is not the culprit.

Comment 10

[Anton Kovalyov (:anton)]

Why can't you use Try?

Comment 11

[Girish Sharma [:Optimizer]]

because in the original bug also, try never showed those leaks. It was only inbound that was showing the leaks. And by never, I mean I tried really hard to see the leaks over multiple try runs with multiple rebuilds.

Comment 12

[Girish Sharma [:Optimizer]]

try push with profiler enabled : https://tbpl.mozilla.org/?tree=Try&rev=cc819fb26341

[This is just precaution, personally try never gave the leaks]

Comment 13

[Girish Sharma [:Optimizer]]

Attachment: reenable proflier in shortcut tests

Let us re enable profiler in the toolbox shortcut test and see what happens.

Comment 14

[Anton Kovalyov (:anton)]

Comment on attachment 777200 [details] [diff] [review]
reenable proflier in shortcut tests

Review of attachment 777200 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 15

[Girish Sharma [:Optimizer]]

landed in fx-team : https://hg.mozilla.org/integration/fx-team/rev/101c751178df

Comment 16

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/101c751178df