Closed Bug 845771 Opened 11 years ago Closed 11 years ago

BaselineCompiler: Not attaching optimized NAME stubs on pdf.js

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch
3.59 KB, patch
bhackett1024
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch Patch (obsolete) — — Splinter Review 
Problem is that we are not emitting GNAME ops in strict mode code (bug 690446). I will take a stab at fixing that now, but this patch just allows using the Name IC with scope chains of length 5 or 6 and fixes most of the gap with trunk on pdf.js.

If we see even deeper chains in the future we can attach a generic stub that just loops over an array of shapes.
Attachment #718932 - Flags: review?(bhackett1024)
Attached patch Patch — — Splinter Review 

        Attachment #718932 -
        Attachment is obsolete: true

        Attachment #718932 -
        Flags: review?(bhackett1024)

        Attachment #718933 -
        Flags: review?(bhackett1024)

        Attachment #718933 -
        Flags: review?(bhackett1024) → review+

    
    

    
  
https://hg.mozilla.org/projects/ionmonkey/rev/c47805f068fc
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: