845864 - [email] Some data points have a weird behaviour

Status: RESOLVED FIXED

(Datazilla Graveyard :: User interface, defect)

Description

[Anthony Ricaud (:rik)]

Attachment: Screenshot

On the attached screenshot, I only display the email app and select the third data point.

You can see that the graph is showing data from another app (a brown one). This is the data point I was looking at before selecting the email data point. The information in the right column is correctly reporting email results though.

Comment 1

[Jonathan Eads ( :jeads )]

The problem arises when 2 different builds have all of the same reference information including the build id, branch name, gaia revision, gecko revision etc... for two different test names. When this occurs, clicking on a point in the "Firefox OS Application Performance" graph returns two data structures with identical build information but two different tests even though a single application and test name are indicated in the UI.

https://datazilla.allizom.org/b2g/refdata/objectstore/json_blob/revisions?branch=master&gaia_revision=ec6d010f907a6905&gecko_revision=baee79387d0a5205489467a9b78f5d6f183283fb&test_id=12&test_type=startup_time&_=1362170529215

I modified the js that displays the Test Replicates to only display the test series the user selected and ignore test data that doesn't match. This resolves the problem in the UI.

We might want to consider making the build id unique in the future rather than using a timestamp. To clarify, the build table in the schema has a unique key set to:

UNIQUE KEY `unique_build` (`product_id`, `test_build_id`, `processor`, `build_type`) (https://github.com/mozilla/datazilla/blob/master/datazilla/model/sql/template_schema/schema_perftest.sql.tmpl#L107)

The product_id points to this table https://github.com/mozilla/datazilla/blob/master/datazilla/model/sql/template_schema/schema_perftest.sql.tmpl#L306

So it's not possible to specify a unique application and test combination in a single SQL WHERE clause when all of the build information between them is identical due to the required join.

1.) If we needed to we could address this at the SQL level by splitting the query into two queries, retrieve the test information with appropriate constraints and then the build information.

2.) We could also make the build.id sent in the JSON https://github.com/mozilla/datazilla/blob/master/datazilla/model/sql/template_schema/schema_perftest.json#L523 a guid instead of a timestamp. The field in the database is a VARCHAR(16) https://github.com/mozilla/datazilla/blob/master/datazilla/model/sql/template_schema/schema_perftest.sql.tmpl#L97 so this would not require any changes in the database and would probably be a better long term strategy.

Regardless, the UI should display the appropriate data without generating any errors now.