845882 - Oracle Taleo job search engine doesn't work since Firefox 19

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Loic]

STR:
1) Open https://nielsen.taleo.net/careersection/3/jobsearch.ftl?lang=en
2) Click on the button "Search for Jobs" (keywords are optional)

Result: the job search engine doesn't disappear and the list of job results is not updated.

Error console:
Erreur : TypeError: _24f.document is undefined
Fichier Source : https://nielsen.taleo.net/careersection/2012PRD.2.5.12.3.0/js/ftlallc.js
Ligne : 2202

Regression range:
m-c
good=2012-10-15
bad=2012-10-16
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=942ed5747b63&tochange=8f145599e4bf

Comment 1

[Loic]

Reporter: http://forums.mozillazine.org/viewtopic.php?f=9&t=2669087

Comment 2

[Alice0775 White]

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/224fddb79a38
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121015103548
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c350c6f28dd1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121015110148
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=224fddb79a38&tochange=c350c6f28dd1
Triggered by:
c350c6f28dd1	Boris Zbarsky — Bug 799875. Make the global scope polluter work even for qualified lookups. r=jst

Comment 3

[Boris Zbarsky [:bzbarsky]]

So the code around that line is:

  var _24f=ftlUtil_getFtlhiddenframe();
  var _250=_24f.document.forms[0];

ftlUtil_getFtlhiddenframe looks like this:

  function ftlUtil_getFtlhiddenframe() {
    var _2dc = frames[FTL_HIDDEN_FRAME_ID];
    if (!isSafari() && _2dc != undefined && _2dc != null) {
        return _2dc;
    }
    var _2dd = frames.length;
    if (!_2dc) {
        var _2de = document.getElementById(FTL_HIDDEN_FRAME_ID).name;
        for (var i = 0; i < _2dd; i++) {
            var _2e0 = frames[i];
            if (_2e0.name == _2de) {
                _2dc = _2e0;
                break;
            }
        }
    } else {
        if (_2dc != undefined) {
            if (_2dd >= 1) {
                _2dc = frames[0];
            }
        }
    }
    return _2dc;
  }

FTL_HIDDEN_FRAME_ID is "ftlhiddenframe".

There's a <iframe id="ftlhiddenframe" name="EmptyFrame"> in the DOM.

So _2dc used to be undefined before bug 799875 but now returns the <iframe>.  Since we're !isSafari(), the function returns that iframe.  Before that it used to do the getElementById and fall into the loop over frames looking for one with the name EmptyFrame.


This is fundamentally the same problem as bug 843075 but now with UA-sniffing.

Comment 4

[Boris Zbarsky [:bzbarsky]]

So the way that function should _probably_ work instead is:

  var _2dc = document.getElementById(FTL_HIDDEN_FRAME_ID);
  if (_2dc) {
    try { 
      return _2dc.contentWindow;
    } catch (e) {
      // Really old IE version?
    }
  }
  // Try whatever fallbacks you need for really old browsers

Comment 5

[Boris Zbarsky [:bzbarsky]]

Tried contacting them via their feedback form and twitter.  We'll see.

Comment 6

[Alex Keybl [:akeybl]]

Two (well, now one since 843075 looks like a WFM bug) non-critical reports of web regressions from bug 799875 still aren't reason to react in FF19/20. It sounds like this will need to be fixed server-side.

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.