Closed Bug 845946 Opened 12 years ago Closed 4 years ago

pdf.js does not remember zoom mode

Categories

(Firefox :: PDF Viewer, enhancement, P4)

19 Branch
x86
Windows 7
enhancement

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: ragimiri, Unassigned)

Details

(Whiteboard: [pdfjs-c-ux])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/20100101 Firefox/19.0 Build ID: 20130215130331 Steps to reproduce: I opened any PDF and changed zoom from Automatic Zoom to Full Width. Then I opened other PDF. Actual results: Zoom mode was changed from Automatic Zoom to Full Width for first PDF. But second PDF was again in Automatic Zoom. Expected results: pdf.js should remember, what zoom mode was used. So if user prefer Full Width instead of Automatic Zoom, pdf.js should open all PDFs in Full Width mode. Or there should be config option for zoom mode.
Severity: normal → enhancement
Component: Untriaged → PDF Viewer
Priority: -- → P4
Whiteboard: [pdfjs-c-ux]
I want to contribute to fix this. Should I submit patch to Firefox or pdf.js (https://github.com/mozilla/pdf.js/) itself?
Attached patch Proposed fixSplinter Review
The UI needs further polish, but I believe functional complete. A "default" key is added to pdfjs.database config. Currently only "zoom" is stored. I can try to add sidebar toggle status if desired.
(In reply to Crend King from comment #1) > I want to contribute to fix this. Should I submit patch to Firefox or pdf.js > (https://github.com/mozilla/pdf.js/) itself? It would be better to do a pull request on github. See also https://github.com/mozilla/pdf.js/pull/3255
I can confirm that this is an issue.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 "Automatic Zoom" is set to default to recently opened pdfs, no matter what zoom type was previously set.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Is this a bug or is it a decision to set to "Automatic Zoom" by default? If it's a decision, we can close this bug as invalid,

The zoom-setting is in fact being saved, but given that SessionStorage is used it's not persistent (in the way that e.g. LocalStorage would be); let's close it as WORKSFORME.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: