845989 - Browser tab crash when working with images loaded from gallery via MozActivity

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Brion Vibber]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130226 Firefox/21.0
Build ID: 20130226042022

Steps to reproduce:

In a web page in the browser, using MozActivity to select a gallery image and then uploading it via FormData+XHR. Also displaying the image onscreen via a data: URL copied into an <img>.

Minimal example at http://leuksman.com/misc/activity usually doesn't crash on the first selection/upload, but reliably crashes on the second selection.

Full example at http://leuksman.com/mw/ --
* switch to mobile view through link at bottom of screen if necessary
* log in (create account if necessary)
* tap menu icon in top-left corner
* tap "Upload" in the menu
* tap "Donate image"
* Select "Gallery"
* Tap on a photo.
* Tap the confirm button on the crop dialog.
* Wait a bit to get back to the wiki...
* type in a description and tap "submit"
* the tab usually crashes during upload



Actual results:

Browser tab frequently crashes, showing a dead tab screen. (If it crashes during photo selection, it may not automatically switch back to the browser. Switch back manually and you'll see the dead tab screen.)


Expected results:

File should upload successfully with no problems.


I'm suspicious of the <img> with the data URL, which probably takes a few extra megabytes of memory... but if it's just hitting a memory limit it'd be nice to get some kind of indication of that.

Comment 1

[Brion Vibber]

Ok I'm beginning to think this is a combination of two things:

1) bug 839630 -- I was asking for type: ['image/jpeg', 'image/png', 'image/gif'] and was getting a PNG back instead of a JPEG.

2) Using too much memory (original PNG blob, data URL version of it, and decoded image in the <img>)

Requesting only 'image/jpeg' to work around bug 839630 uses a lot less memory and seems not to crash as much.

Comment 2

[Brion Vibber]

Closing this out in favor of existing bug 839630 and also filing bug 846015 for another issue I noticed with the gallery.