846079 - [calendar] Don't block UI when loading settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Comment 1

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8368

Pointer to Github pull-request

Comment 2

[James Lal [:lightsofapollo]]

landed here (awhile ago) https://github.com/mozilla-b2g/gaia/commit/bcea26f1c5f816cc38f267200e2e8082a03e5117

Comment 3

[James Lal [:lightsofapollo]]

uplift commit: bcea26f1c5f816cc38f267200e2e8082a03e5117
v1-train: https://github.com/mozilla-b2g/gaia/commit/da5f08e77cee3c6ddac9e66ee7aa57dd9411064c

Comment 4

[Julien Wajsberg [:julienw] (PTO -> may 13)]

James, is it worth uplifting to v1.0.1 ? If yes, could you please explain why (like: the user impact) ?

Comment 5

[James Lal [:lightsofapollo]]

The impact here is fairly minimal for performance (10-30ms?) but it blocks some bigger perf work that we did later on (the bigger don't block on idb bug).

Comment 6

[Julien Wajsberg [:julienw] (PTO -> may 13)]

trying to nominate ;)

Comment 7

[Michael Vines [:m1] [:evilmachines]]

(tef- as I think we're accepting of the current settings start performance for v1.0.1)

Comment 8

[Julien Wajsberg [:julienw] (PTO -> may 13)]

Michael, for the record, this is for the Calendar app ;) but I understand this is not in 1.0.1 priorities either so I won't renom.

Comment 9

[James Lal [:lightsofapollo]]

OK- this actually blocks the overall oAuth2 effort from landing on v1.0.1... its been baking on v1-train and master for a good period of time... Without this uplifting will be very difficult.

Comment 10

[Dylan Oliver [:doliver]]

tef+ -- blocks a blocker. Discussed with James and Alex and decided that uplifting this patch was the cleanest path forward.

Comment 11

[James Lal [:lightsofapollo]]

in v1.0.1: https://github.com/mozilla-b2g/gaia/commit/71d98ddbc3e65173cc9a28dd7c98ebeb7d9fb1a6

Comment 12

[Deepa Subramanian]

Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?

Comment 13

[Kevin Grandon :kgrandon]

Attachment: Patch followup

This is James's follow-up patch.

Comment 14

[Kevin Grandon :kgrandon]

Follow-up landed in master: https://github.com/mozilla-b2g/gaia/commit/46ef0855021babedae5dc93a51d5dae54d0616de

Comment 15

[Julien Wajsberg [:julienw] (PTO -> may 13)]

a follow-up 5 months later ?

Could you attach this to another bug so that we can eg ask leo+ on it ? (is it necessary btw ?)

Comment 16

[Kevin Grandon :kgrandon]

Just saw the open pull request sitting there, so I thought I'd land it :)

I don't really feel that it's necessary to uplift - only a few typo changes, and I thought that the requirements for leo+ were more strict now?

Comment 17

[Julien Wajsberg [:julienw] (PTO -> may 13)]

tbh I haven't looked up the PR ;) yep seems good to keep it like this.