Closed Bug 846079 Opened 9 years ago Closed 9 years ago

[calendar] Don't block UI when loading settings

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

defect
Not set
normal

Tracking

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

RESOLVED FIXED
blocking-b2g tef+
Tracking Status
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: jlal, Assigned: jlal)

References

Details

(Whiteboard: [FFOS_perf][qa-])

Attachments

(2 files)

No description provided.
Blocks: 816610
landed here (awhile ago) https://github.com/mozilla-b2g/gaia/commit/bcea26f1c5f816cc38f267200e2e8082a03e5117
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
uplift commit: bcea26f1c5f816cc38f267200e2e8082a03e5117
v1-train: https://github.com/mozilla-b2g/gaia/commit/da5f08e77cee3c6ddac9e66ee7aa57dd9411064c
tracking-b2g18: ? → ---
Whiteboard: [FFOS_perf]
James, is it worth uplifting to v1.0.1 ? If yes, could you please explain why (like: the user impact) ?
Assignee: nobody → jlal
Flags: needinfo?(jlal)
The impact here is fairly minimal for performance (10-30ms?) but it blocks some bigger perf work that we did later on (the bigger don't block on idb bug).
Flags: needinfo?(jlal)
trying to nominate ;)
blocking-b2g: --- → tef?
(tef- as I think we're accepting of the current settings start performance for v1.0.1)
blocking-b2g: tef? → -
Michael, for the record, this is for the Calendar app ;) but I understand this is not in 1.0.1 priorities either so I won't renom.
Summary: Don't block UI when loading settings → [calendar] Don't block UI when loading settings
OK- this actually blocks the overall oAuth2 effort from landing on v1.0.1... its been baking on v1-train and master for a good period of time... Without this uplifting will be very difficult.
blocking-b2g: - → tef?
Blocks: gaia-caldav2
tef+ -- blocks a blocker. Discussed with James and Alex and decided that uplifting this patch was the cleanest path forward.
blocking-b2g: tef? → tef+
Keywords: verifyme
Keywords: verifyme
Whiteboard: [FFOS_perf] → [FFOS_perf][qa-]
Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?
Attached file Patch followup
This is James's follow-up patch.
Attachment #792318 - Flags: review+
a follow-up 5 months later ?

Could you attach this to another bug so that we can eg ask leo+ on it ? (is it necessary btw ?)
Flags: needinfo?(kgrandon)
Just saw the open pull request sitting there, so I thought I'd land it :)

I don't really feel that it's necessary to uplift - only a few typo changes, and I thought that the requirements for leo+ were more strict now?
Flags: needinfo?(kgrandon)
tbh I haven't looked up the PR ;) yep seems good to keep it like this.
You need to log in before you can comment on or make changes to this bug.