Closed
Bug 846102
Opened 12 years ago
Closed 12 years ago
Text selection cursor is misaligned in subframes
Categories
(Firefox for Android Graveyard :: Text Selection, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: Margaret, Assigned: Margaret)
References
()
Details
Attachments
(1 file)
|
3.53 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
I ran into this on http://people.mozilla.org/~mwargers/tests/autocomplete_forms/parentframe.html.
Regular text selection works within iframes, so this is specific to the cursor.
|
Assignee | |
Comment 1•12 years ago
|
||
The QUERY_CARET_RECT [1] result already accounts for any sub-frame offset that might exist, so we were mistakenly adding the offset to the cursor position. It's a nice bonus that we don't need to call _getViewOffset for cursor positioning with this patch.
[1] http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/base/nsIDOMWindowUtils.idl#860
Attachment #719698 -
Flags: review?(bnicholson)
|
||
Updated•12 years ago
|
Attachment #719698 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•