846169 - Test timeouts should have an error message tbpl will recognize as a failure, and should include the name of the running test

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Phil Ringnalda (:philor)]

Typical timeouts look like https://tbpl.mozilla.org/php/getParsedLog.php?id=20157251&tree=Mozilla-Inbound

TEST-START | tests/test-selection.test Selection Listener on frame
(60 or 80 lines of the usual debug log noise during a hang, as GC takes the opportunity to run)
Traceback (most recent call last):
  File "jetpack/bin/cfx", line 33, in <module>
    cuddlefish.run()
  File "/builds/slave/test/build/jetpack/python-lib/cuddlefish/__init__.py", line 602, in run
    test_all_packages(env_root, defaults=options.__dict__)
  File "/builds/slave/test/build/jetpack/python-lib/cuddlefish/__init__.py", line 484, in test_all_packages
    env_root=env_root)
  File "/builds/slave/test/build/jetpack/python-lib/cuddlefish/__init__.py", line 927, in run
    bundle_sdk=options.bundle_sdk)
  File "/builds/slave/test/build/jetpack/python-lib/cuddlefish/runner.py", line 696, in run_app
    OUTPUT_TIMEOUT)
Exception: Test output exceeded timeout (60s).
program finished with exit code 1
elapsedTime=618.647612
TinderboxPrint:jetpack<br/>0/0

while a version aimed at not inducing sheriff rage would look like

TEST-START | tests/test-selection.test Selection Listener on frame
(60 or 80 lines of the usual debug log noise during a hang, as GC takes the opportunity to run)
TEST-UNEXPECTED-FAIL | tests/test-selection.test Selection Listener on frame | Test output exceeded timeout (60s).

Comment 1

[Dave Townsend [:mossop]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/824

Pointer to Github pull-request

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b81ddb118d8c4964759b8a5da870e24ac36e9b4c
Bug 846169: Display a message that tbpl will recognise for test timeouts when in parseable output mode. r=ochameau

Comment 3

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f23a54b4132bcb4e792686c7e02bb8735af5d1ff
Bug 846169: Display a message that tbpl will recognise for test timeouts when in parseable output mode. r=ochameau
(cherry picked from commit b81ddb118d8c4964759b8a5da870e24ac36e9b4c)

Comment 4

[[github robot]]

Commit pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b81ddb118d8c4964759b8a5da870e24ac36e9b4c
Bug 846169: Display a message that tbpl will recognise for test timeouts when in parseable output mode. r=ochameau