846320 - Offset mBasePosition by mStartTime when seeking.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Paul Adenot (:padenot)]

I found this when trying to remove all the assertions that fire when doing a content/media mochitest run, I forgot to offset |mSeekTime| by |mStartTime| when assigning to |mBasePosition|, resulting in an assert blowing up repeatedly on test_seek.html, specifically when playing split.webm, that happens to start at 2.00 seconds.

With this, I have 0 assertions firing during a full content/media mochitest run (locally).

Comment 1

[Paul Adenot (:padenot)]

Attachment: Offset mBasePosition by mStartTime when seeking. r=

Comment 2

[Paul Adenot (:padenot)]

Attachment: Remove SimpleTest.expectAssertions in test_seek.html. r=

This patch should be applied on top of the patches from bug 845676.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also, there are a lot of assertions in content/media that are firing only on Windows builds... sometimes in *very* large numbers.  Does this fix those?

Comment 4

[Paul Adenot (:padenot)]

I'll have a look today, I usually don't work on Windows.

Comment 5

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08a66b173b28
https://hg.mozilla.org/integration/mozilla-inbound/rev/450783152a46

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/08a66b173b28
https://hg.mozilla.org/mozilla-central/rev/450783152a46

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to David Baron [:dbaron] (don't cc:, use needinfo? instead) from comment #3)
> Also, there are a lot of assertions in content/media that are firing only on
> Windows builds... sometimes in *very* large numbers.  Does this fix those?

For the record, I think these are covered by bug 839650.