Closed
Bug 846353
Opened 12 years ago
Closed 12 years ago
Typos in robocop tests
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
|
6.00 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
The recent change to report timeouts in waitForText shows that some robocop tests are waiting for text that never appears. Some of these cases are simply typos: missing letters or incorrect case.
|
Assignee | |
Comment 1•12 years ago
|
||
Unfortunately, there is a small chance that these fixes will increase instability: we won't wait as long, so there is a greater chance that the UI is still changing.
Attachment #719519 -
Flags: review?(jmaher)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → gbrown
|
||
Comment 2•12 years ago
|
||
Comment on attachment 719519 [details] [diff] [review]
fix typos
Review of attachment 719519 [details] [diff] [review]:
-----------------------------------------------------------------
it would be awesome to get all the strings in a single place some day, otherwise some great cleanup. I wonder why these tests were passing with some of the typos.
Attachment #719519 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•