846471 - Poison NtWriteFile

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

Poisoning NtWriteFile itself is simple, but doing so causes the writing of the stacks to hit the poised NtWriteFile recursively.

To fix this, this patch generalizes the fd list we keep on OS X to be a list of "file IDs". On unix it is just the file descriptors and on windows it is now the HANDLE.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Also ignore stdout and stderr

Tests were failing on debug windows build since NtFileWrite is also called from printf.

https://tbpl.mozilla.org/?tree=Try&rev=2ca43e6644c9

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 720193 [details] [diff] [review]
Also ignore stdout and stderr

Review of attachment 720193 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/build/mozPoisonWriteBase.cpp
@@ +275,5 @@
>  
>    PRLock *Lock;
>    {
> +    DebugFilesAutoLock lockedScope;
> +    delete &getDebugFileIDs();

This looks really nasty to me but perhaps because it's the first time I encounter code that does this. Perhaps getDebugFileIDs should return a pointer or I can just get use to this pattern.

::: xpcom/build/mozPoisonWriteWin.cpp
@@ +53,5 @@
> +
> +void AbortOnBadWrite(HANDLE aFile)
> +{
> +  static HANDLE stdoutHandle = reinterpret_cast<HANDLE>(_get_osfhandle(1));
> +  static HANDLE stderrHandle = reinterpret_cast<HANDLE>(_get_osfhandle(2));

can't we just permanently keep stdout/stderr in the debug fd?

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

New try push to

https://tbpl.mozilla.org/?tree=Try&rev=77c4bb0421d0

Hopefully the tree is in good enough shape this time.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13f62f5274e7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/13f62f5274e7