846816 - The hit targets for the email and password fields for logging into facebook during import contacts are all shifted down

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 3/1/2013
Device: Unagi

Steps:

1. Go to contacts --> enable facebook
2. Try to login

Expected:

When hitting each field (email and password), that text should be selected, allowing you to start typing text.

Actual:

Hitting the actual text fields does nothing. If you try to touch a hit target a bit lower than the text field, then the text field gets selected.

This is a very recent regression and needs to block.

Comment 1

[Jason Smith [:jsmith]]

I have a strong feeling this is a regression from bug 844326.

Comment 2

[Jason Smith [:jsmith]]

Last working: 2/28/2013
First bad: 3/1/2013

So it's definitely something that landed yesterday.

Comment 3

[[:fabrice] Fabrice Desré]

Bisecting leads to this culprit:

The first bad revision is:
changeset:   118636:e5b09bb5efb9
user:        Anthony Jones <[e-mail]>
date:        Thu Feb 28 14:22:59 2013 -0500
summary:     Bug 833795 - Pass screen relative co-ordinates to APZC. r=cjones, a=leo+

Comment 4

[Jason Smith [:jsmith]]

Ah, guess I was wrong.

Comment 5

[Alex Keybl [:akeybl]]

tef?->leo? since it wouldn't appear that v1.0.1 is affected.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Let's back out.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Bug 833795 backed out of both branches. Please make sure we get a test for this before it re-lands, though.

Comment 8

[Jason Smith [:jsmith]]

Probably doesn't need to go through triage now we've done the backout.

Comment 9

[David Scravaglieri [:scravag]]

Fabrice what's the status here ? It blocks the bug 833795 it's marked as resolved fixed but I don't see any patch.

Comment 10

[Jason Smith [:jsmith]]

(In reply to David Scravaglieri [:scravag] from comment #9)
> Fabrice what's the status here ? It blocks the bug 833795 it's marked as
> resolved fixed but I don't see any patch.

The patch in the blocking bug was backed out, so this should be fixed now so long as the blocking bug in it's original form does not get checked in.