846845 - [MMS][SMS][Tests] add tests and simplify Utils

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Rick Waldron [:rwaldron]]

Simplify Utils.getFormattedHour(time) and provide tests to support the expected behaviour

Comment 1

[Rick Waldron [:rwaldron]]

This will address all of the non-DOM functionality in Utils.* (sms/js/utils.js)

Comment 2

[Rick Waldron [:rwaldron]]

Attachment: Redirect to https://github.com/mozilla-b2g/gaia/pull/8414

Tests and code simplification for sms/js/utils.js

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 720135 [details]
Redirect to https://github.com/mozilla-b2g/gaia/pull/8414

r=me with the last comments fixed

thanks a lot

Comment 4

[Rick Waldron [:rwaldron]]

Fixed, rebased, squashed and pushed: https://github.com/mozilla-b2g/gaia/pull/8414

Comment 5

[Julien Wajsberg [:julienw]]

master: https://github.com/mozilla-b2g/gaia/commit/57a600dca3d3af68cb71b399f11096fb0e367017

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 720135 [details]
Redirect to https://github.com/mozilla-b2g/gaia/pull/8414

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: no
Testing completed: yes, the sms app works fine
Risk to taking this patch (and alternatives if risky): low, we added unit tests for each function of this file.
String or UUID changes made by this patch: none

I'd like this on v1-train because this brings unit tests, probably some minor perf improvement, and we'll need this in upcoming patches as well.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 57a600dca3d3af68cb71b399f11096fb0e367017 as:
v1-train: 07b494e9e1a4f29ac2f7ae4bfa408c8da1a77ec2