Closed
Bug 846871
Opened 11 years ago
Closed 10 years ago
make contact's rendering test work when there is no contact
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
2.0 S2 (23may)
People
(Reporter: julienw, Assigned: hub)
References
Details
(Keywords: perf, Whiteboard: [c=automation p=0 s= u=])
Attachments
(1 file)
In Bug 837673 we landed a working performance test for Contacts. However it fails when there is no contact at all. This bug is to make it work in this case.
|
Reporter | |
Updated•11 years ago
|
|
||
Updated•11 years ago
|
Whiteboard: [c=instrumentation p=] → [c=automation p= s= u=]
|
Assignee | |
Updated•11 years ago
|
Priority: -- → P1
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → hub
Component: Gaia → Gaia::Contacts
Whiteboard: [c=automation p= s= u=] → [c=automation p=2 s= u=]
|
|
Assignee | |
Updated•10 years ago
|
Priority: P1 → P2
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8426421 -
Flags: review?(etienne)
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [c=automation p=2 s= u=] → [c=automation p=1 s= u=]
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8426421 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19495 Am I looking at the right patch? This bug was about the contact app, not the call log.
Attachment #8426421 -
Flags: review?(etienne)
Flags: needinfo?(hub)
|
|
Assignee | |
Comment 3•10 years ago
|
||
uh oh. Looks like I got confused on everything from the beginning and yes this is about contact while the bug I thought was about the call log. Will sort that out and ask review again with a proper bug. Sorry about that.
Flags: needinfo?(hub)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Actually this is not a problem: the tests work in contacts. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1014821 for the call log. Sorry for all the confusion.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Whiteboard: [c=automation p=1 s= u=] → [c=automation p=0 s= u=]
|
|
Reporter | |
Comment 5•10 years ago
|
||
Are you sure it works with an empty contact DB? If yes, maybe it works since you fixed bug 846909.
|
|
Assignee | |
Comment 6•10 years ago
|
||
Yes, I tested it.
|
|
||
Updated•10 years ago
|
Target Milestone: --- → 2.0 S2 (23may)
You need to log in
before you can comment on or make changes to this bug.
Description
•