Open Bug 846932 Opened 11 years ago Updated 2 years ago

Rotate gesture is slow when zoomed out in sufficiently large image

Categories

(Firefox :: General, defect)

All
macOS
defect

Tracking

()

People

(Reporter: reuben, Unassigned)

References

Details

Attachments

(1 obsolete file)

STR:

1) Open https://s3.amazonaws.com/f.cl.ly/items/2V0L2P052v1V0J0D1R11/IMG_20130301_134335.jpg (or any sufficiently large image).
2) Use gesture to rotate image
3) Zoom out (Cmd+-)
4) Use gesture again

Rotating the image when zoomed out is considerably slower.
Assignee: nobody → waterlo1
A large part of the time lost (around 50% or more) is spent drawing the background, which is a tiled image of dark gray noise.

For very large images, this also means a very large background.  The background is constantly changing size (especially height on wider screens that are wide enough to show the image but not tall enough) as the image is rotated.

A few possible solutions:
--Forcibly make the background larger than it needs to be, so it doesn't need to be repainted when the image is rotated?
--For very large images, replace the noisy gray background with a solid color
Attached file Full profile of the lag (obsolete) —
Attached is a full profile of where the lag is occurring.  Also, it seems like it's working better at the moment than it did in the past--I feel like it was much laggier in the past.
Attachment #735350 - Attachment is obsolete: true
Re-did the profile except uploading it to the correct place instead of uploading it here.

Link:

http://people.mozilla.com/~bgirard/cleopatra/#report=79e215a446240ff176f623abbd7d7d0a90f50bc8
Forgot to note:

Usually there would be a lag-spike in the gesture right about in the middle of the gesture when the image's corners were outside of the window (the diagonal length of the image was greater than the width of the window).
(In reply to Brandon Waterloo from comment #3)
> Re-did the profile except uploading it to the correct place instead of
> uploading it here.
> 
> Link:
> 
> http://people.mozilla.com/~bgirard/cleopatra/
> #report=79e215a446240ff176f623abbd7d7d0a90f50bc8

Which point in the profile is the rotation occurring? I don't see any jank in that profile. Can you re-run the profile but do the rotation many times or in some exaggerated way to make it show up better?
There are multiple in that profile--each of the small bumps is a gesture
Here's another profile with a lot more red and lag (on a much larger image):

http://people.mozilla.com/~bgirard/cleopatra/#report=0a7c9d00316eddb054e42651486b1921388ae43f
Un-assigning myself from this since I have very little graphics expertise and the semester is ending in a week.
Assignee: waterlo1 → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: