847194 - Intermittent test_CrossSiteXHR.html, test_playback_errors.html, test_contextmenu.html | Assertion count 1 is greater than expected range (RECURSION_LEVEL_SAFE_TO_FINISH(table): 'RECURSION_LEVEL_SAFE_TO_FINISH(table)')

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20271053&tree=Mozilla-Inbound&full=1

builder: mozilla-inbound_xp-debug_test-mochitest-1
slave: talos-r3-xp-052

22:09:35     INFO -  3803 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | shouldn't have failed in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"y x-my-header", expectedResponseHeaders:[]})
22:09:35     INFO -  3804 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong status in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"y x-my-header", expectedResponseHeaders:[]})
22:09:35     INFO -  3805 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong status text for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"y x-my-header", expectedResponseHeaders:[]})
22:09:35     INFO -  3806 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong responseXML in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"y x-my-header", expectedResponseHeaders:[]})
22:09:35     INFO -  3807 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong responseText in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"y x-my-header", expectedResponseHeaders:[]})
22:09:35     INFO -  3808 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong responseText in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"y x-my-header", expectedResponseHeaders:[]})
22:09:35     INFO -  3809 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | |xhr.getResponseHeader()|wrong response header (x-my-header) in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"y x-my-header", expectedResponseHeaders:[]})
22:09:35     INFO -  3810 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | |xhr.getAllResponseHeaderss()|wrong response header (x-my-header) in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"y x-my-header", expectedResponseHeaders:[]})
22:09:35     INFO -  ###!!! ASSERTION: RECURSION_LEVEL_SAFE_TO_FINISH(table): 'RECURSION_LEVEL_SAFE_TO_FINISH(table)', file e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/obj-firefox/xpcom/build/pldhash.cpp, line 369
22:09:36     INFO -  --DOMWINDOW == 152 (168A8C20) [serial = 186] [outer = 00000000] [url = about:blank]
22:09:36     INFO -  --DOMWINDOW == 151 (17A78DC8) [serial = 187] [outer = 00000000] [url = about:blank]
22:09:36     INFO -  --DOMWINDOW == 150 (0D4207B0) [serial = 274] [outer = 17682210] [url = about:blank]
22:09:36     INFO -  --DOMWINDOW == 149 (0D71D118) [serial = 276] [outer = 1768B338] [url = about:blank]
22:09:36     INFO -  --DOMWINDOW == 148 (0D256080) [serial = 278] [outer = 176943B0] [url = about:blank]
22:09:36     INFO -  --DOMWINDOW == 147 (160FE720) [serial = 283] [outer = 16173BF8] [url = about:blank]
22:09:36     INFO -  --DOMWINDOW == 146 (178351A8) [serial = 285] [outer = 17707430] [url = about:blank]
22:09:36     INFO -  --DOMWINDOW == 145 (165A4760) [serial = 287] [outer = 177103F0] [url = about:blank]
22:09:36     INFO -  3811 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | shouldn't have failed in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-header z", expectedResponseHeaders:[]})
22:09:36     INFO -  3812 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong status in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-header z", expectedResponseHeaders:[]})
22:09:36     INFO -  3813 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong status text for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-header z", expectedResponseHeaders:[]})
22:09:36     INFO -  3814 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong responseXML in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-header z", expectedResponseHeaders:[]})
22:09:36     INFO -  3815 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong responseText in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-header z", expectedResponseHeaders:[]})
22:09:36     INFO -  3816 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong responseText in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-header z", expectedResponseHeaders:[]})
22:09:36     INFO -  3817 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | |xhr.getResponseHeader()|wrong response header (x-my-header) in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-header z", expectedResponseHeaders:[]})
22:09:36     INFO -  3818 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | |xhr.getAllResponseHeaderss()|wrong response header (x-my-header) in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-header z", expectedResponseHeaders:[]})
22:09:36     INFO -  3819 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | shouldn't have failed in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-hea(er", expectedResponseHeaders:[]})
22:09:36     INFO -  3820 INFO TEST-PASS | /tests/content/base/test/test_CrossSiteXHR.html | wrong status in test for ({pass:1, method:"GET", responseHeaders:{'x-my-header':"x header"}, exposeHeaders:"x-my-header, y-my-hea(er", expectedResponseHeaders:[]})

etc...

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20357009&tree=Mozilla-Inbound&full=1#error0

Comment 2

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=20454134&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-1 on 2013-03-08 02:29:12
slave: talos-r3-xp-026

02:34:02     INFO -  4209 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_CrossSiteXHR.html | Assertion count 1 is greater than expected range 0-0 assertions.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20644882&tree=Mozilla-Inbound&full=1#error0

Comment 4

[Paul Adenot (:padenot)]

I'll do that, it _should_ just be a matter of locking properly.

Stack: http://khuey.pastebin.mozilla.org/2219919

Comment 5

[Ralph Giles (:rillian)]

Pasting stack trace from comment #4:

05:44:56     INFO -  ###!!! ASSERTION: RECURSION_LEVEL(table_) > 0: 'RECURSION_LEVEL(table) > 0', file e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/obj-firefox/xpcom/build/pldhash.cpp, line 670
05:44:57     INFO -  1142 INFO TEST-PASS | /tests/browser/base/content/test/test_contextmenu.html | Got context menu XUL
05:44:57     INFO -  1143 INFO TEST-KNOWN-FAIL | /tests/browser/base/content/test/test_contextmenu.html | Wait for subwindow to load... (This should usually happen once.)
05:44:57     INFO -  1144 INFO TEST-PASS | /tests/browser/base/content/test/test_contextmenu.html | Got context menu XUL
05:44:57     INFO -  1145 INFO TEST-PASS | /tests/browser/base/content/test/test_contextmenu.html | Starting test #1
05:44:57     INFO -  1146 INFO TEST-PASS | /tests/browser/base/content/test/test_contextmenu.html | checking if popup is closed
05:44:57     INFO -  1147 INFO TEST-PASS | /tests/browser/base/content/test/test_contextmenu.html | Starting test #2
05:45:07     INFO -  nsTHashtable<nsBaseHashtableET<nsUint32HashKey,nsAutoPtr<mozilla::OggCodecState> > >::GetEntry(unsigned int const &) [obj-firefox/dist/include/nsTHashtable.h:148]
05:45:07     INFO -  nsClassHashtable<nsUint32HashKey,mozilla::OggCodecState>::Get(unsigned int const &,mozilla::OggCodecState * *) [obj-firefox/dist/include/nsClassHashtable.h:65]
05:45:07     INFO -  mozilla::OggReader::NextOggPacket(mozilla::OggCodecState *) [content/media/ogg/OggReader.cpp:924]
05:45:07     INFO -  mozilla::OggReader::DecodeVideoFrame(bool &,__int64) [content/media/ogg/OggReader.cpp:832]
05:45:07     INFO -  mozilla::MediaDecoderReader::DecodeToFirstVideoData() [content/media/MediaDecoderReader.cpp:417]
05:45:07     INFO -  mozilla::MediaDecoderReader::FindStartTime(__int64 &) [content/media/MediaDecoderReader.cpp:451]
05:45:07     INFO -  mozilla::MediaDecoderStateMachine::FindStartTime() [content/media/MediaDecoderStateMachine.cpp:2505]
05:45:07     INFO -  mozilla::MediaDecoderStateMachine::DecodeMetadata() [content/media/MediaDecoderStateMachine.cpp:1841]
05:45:07     INFO -  mozilla::MediaDecoderStateMachine::DecodeThreadRun() [content/media/MediaDecoderStateMachine.cpp:481]
05:45:07     INFO -  nsRunnableMethodImpl<void ( mozilla::MediaDecoderStateMachine::*)(void),1>::Run() [obj-firefox/dist/include/nsThreadUtils.h:368]
05:45:07     INFO -  nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:627]
05:45:07     INFO -  NS_ProcessNextEvent_P(nsIThread *,bool) [obj-firefox/xpcom/build/nsThreadUtils.cpp:238]
05:45:07     INFO -  nsThread::ThreadFunc(void *) [xpcom/threads/nsThread.cpp:265]

Comment 7

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=20869427&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-1 on 2013-03-20 01:08:11
slave: talos-r3-xp-051

01:12:29  WARNING -  TEST-UNEXPECTED-FAIL | /tests/browser/base/content/test/test_contextmenu.html | Exited with code -2147483645 during test run
01:12:42     INFO -  PROCESS-CRASH | /tests/browser/base/content/test/test_contextmenu.html | application crashed [@ PL_DHashTableOperate]
01:12:43    ERROR - Return code: 1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=21122872&tree=Mozilla-Inbound

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=21216294&tree=Mozilla-Inbound

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=21225518&tree=Mozilla-Inbound

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=21223071&tree=Mozilla-Inbound

Comment 12

[Legacy TBPL/Treeherder Robot]

reuben
https://tbpl.mozilla.org/php/getParsedLog.php?id=21239948&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-1 on 2013-03-29 01:36:07
slave: talos-r3-xp-064

02:11:23     INFO -  Assertion failure: ((*(uint32_t*)(table->entryStore + ((uint32_t)1 << (32 - (table)->hashShift)) * table->entrySize)) == 0 || (*(uint32_t*)(table->entryStore + ((uint32_t)1 << (32 - (table)->hashShift)) * table->entrySize)) == ((uint32_t)-1)), at e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/obj-firefox/xpcom/build/pldhash.cpp:368
02:11:25  WARNING -  TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_playback_errors.html | Exited with code -2147483645 during test run
02:11:39  WARNING -  PROCESS-CRASH | /tests/content/media/test/test_playback_errors.html | application crashed [@ PL_DHashTableFinish]
02:11:41    ERROR - Return code: 1

Comment 13

[Paul Adenot (:padenot)]

Attachment: Protect mCodecStates from concurrent accesses. r=

Try run: https://tbpl.mozilla.org/?tree=Try&rev=9562ad23e75f

Comment 14

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 733909 [details] [diff] [review]
Protect mCodecStates from concurrent accesses. r=

Review of attachment 733909 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should also protect accesses to mKnownStreams.

Since we always use mKnownStreams and mCodecStates together, I think we should factor them out into their own threadsafe object, with a clear interface which manages the synchronization for the caller. It can have its own monitor.

Something like:

class OggCodecStore {
public:
  void Add(OggCodecState*, int serial);
  bool Contains(int serial);
  OggCodecState* Get(int serial);
}

Comment 15

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Chris Pearce (:cpearce) from comment #14)
> Something like:
> 
> class OggCodecStore {
> public:
>   void Add(OggCodecState*, int serial);
>   bool Contains(int serial);
>   OggCodecState* Get(int serial);
> }

An yes, with this design Contains() can return false on one thread and then a codecstate can immediately be added on another thread so the just-returned value is now wrong. I think this is OK, this would only affect our code that calculates HTMLMediaElement.buffered, and it's not a big deal if we under-estimates the buffered ranges for a tick.

Comment 16

[Paul Adenot (:padenot)]

Attachment: Protect mCodecStates from concurrent accesses. r=

Comment 17

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 735154 [details] [diff] [review]
Protect mCodecStates from concurrent accesses. r=

Review of attachment 735154 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/ogg/OggReader.cpp
@@ +1872,5 @@
>  #endif
>  }
>  
> +OggCodecStore::OggCodecStore()
> +:mMonitor("CodecStore")

: mMonitor("CodecStore")

::: content/media/ogg/OggReader.h
@@ +34,5 @@
> +    OggCodecStore();
> +    void Add(uint32_t serial, OggCodecState* codecState);
> +    bool Contains(uint32_t serial);
> +    OggCodecState* Get(uint32_t serial);
> +    bool IsKnownStream(uint32_t aSerial);

Actually it seems that IsKnownStreams(serial)==Contains(serial), so we may as well remove IsKnownStreams() and mKnownStreams() and just use Contains() instead.

Comment 18

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1348d28d70fc

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1348d28d70fc