847257 - Update Help for changes from Bug 624432.

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Edmund Wong (:ewong)]

When composing an e-mail and changing the account, the signing and
encryption preferences aren't changed according to the new account.
This has been changed by bug 624432.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Update help. (v1)

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 720507 [details] [diff] [review]
Update help. (v1)

Review of attachment 720507 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/locales/en-US/chrome/common/help/mailnews_security.xhtml
@@ +380,5 @@
>    </li>
>  </ul>
>  
> +<p>When composing a message, and changing to a different account, the signing
> +  and encryption preferences are also changed to reflect the different account's

Ian, shouldn't the second "different" be something like "other" or "new" instead? Feels awkward to me as-is.

Comment 3

[rsx11m]

I'd say "other" or, more specific, "selected". The "new" may be ambiguous, first thinking about account creation rather than just picking a different account.

Comment 4

[Ian Neal]

Comment on attachment 720507 [details] [diff] [review]
Update help. (v1)

>+<p>When composing a message, and changing to a different account, the signing
>+  and encryption preferences are also changed to reflect the different account's
>+  settings.</p>
How about:
<p>When composing a message, and you select a different account, the signing
  and encryption preferences are updated to reflect the newly selected
  account&apos;s settings.</p>

Note the use of &apos; too. Not sure about the number of commas though.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Now it gets interesting. A gerund and a verb in the present form, connected to each other using not only a conjunction but also a comma. I have to admit that I don't know enough about English to judge whether anything is wrong with the above, but I'm pretty sure it'd be OK if we kept it simple, like so:

When you compose a message and select a different account, (...) to reflect the settings of the newly selected account.

Here the first part (before the comma) consists of two actions that are both on the same level ("let's say you were going to..."), so using a simple "and" to connect them suffices. For the second part I thought using the "of" genitive would be better since "account" is not a person or similar entity (which is the rule that I remember; don't know whether it applies here or both forms are fine).

Anyway, I guess I'm guilty of bikeshedding by now so feel free to go with Ian's suggestion if you like Edmund. ;-)

Comment 6

[rsx11m]

Personally, I'd go with Jens' version as it reads easier.

Comment 7

[Ian Neal]

(In reply to rsx11m from comment #6)
> Personally, I'd go with Jens' version as it reads easier.

Ditto.

Comment 8

[Edmund Wong (:ewong)]

Attachment: Update help (v2)

Comment 9

[Edmund Wong (:ewong)]

Attachment: Update help (v2)

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 727074 [details] [diff] [review]
Update help (v2)

Review of attachment 727074 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nits fixed.

::: suite/locales/en-US/chrome/common/help/mailnews_security.xhtml
@@ +379,5 @@
>      </ul>
>    </li>
>  </ul>
>  
> +<p>When compose a message and select a different account, the signing

Missing "you" after "When".

@@ +380,5 @@
>    </li>
>  </ul>
>  
> +<p>When compose a message and select a different account, the signing
> +  and encryption preferences are updated to reflect the different account&apos;s

We settled on "newly selected" instead of the second "different".

Comment 11

[Edmund Wong (:ewong)]

Attachment: Update help (v3)

Comment 12

[Edmund Wong (:ewong)]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/fffac8845d95