847352 - Preload SystemMessageHandler.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

SystemMessageHandler.js is used by most of the core apps and this is hard to move it out of the main startup path since this is a reasonable place for navigator.setMessageHandler to be called.

Initializing the service at startup can be avoided like we do for SettingsManager.js

Comment 1

[[:fabrice] Fabrice Desré]

Comment on attachment 720633 [details] [diff] [review]
Patch

Review of attachment 720633 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed

::: dom/ipc/preload.js
@@ +78,5 @@
>    Cc["@mozilla.org/contentsecuritypolicy;1"].createInstance(Ci["nsIContentSecurityPolicy"]);
>  
>    /* Applications Specific Helper */
>    Cc["@mozilla.org/settingsManager;1"].getService(Ci["nsIDOMSettingsManager"]);
> +  Cc["@mozilla.org/system-message-manager;1"].getService(Ci["nsIDOMNavigatorSystemMessages"]);

That needs to be guarded by #ifdef MOZ_SYS_MSG

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c2e3ea6afa6

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cb5eeb57318

Comment 4

[Ryan VanderMeulen [:RyanVM]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/6c2e3ea6afa6

Reminder, B2G work should be landing on birch, not inbound. Also, the reason for the backout was for mass test bustage. Please run your patches through Try before re-landing.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/4c3d16be5645

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4c3d16be5645