Closed
Bug 847369
Opened 12 years ago
Closed 12 years ago
jit-tests no longer run as part of make check on buildbot jobs
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla22
People
(Reporter: jandem, Assigned: gps)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
981 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I just pushed a patch with a failing jit-test to try [1] and only the root-analysis build caught it. The browser build itself was green, even though I'd expect it to run jit-tests too, as part of "make check".
Looking at a random mozilla-inbound log [2], it seems we no longer run jit_test.py as part of the build/"make check".
[1] https://tbpl.mozilla.org/?tree=Try&rev=275bd5815a2f
[2] For instance https://tbpl.mozilla.org/php/getParsedLog.php?id=20292731&tree=Mozilla-Inbound&full=1
Comment 1•12 years ago
|
||
Suspect bug 638219 is relevant to this.
(Adjusting summary, since TBPL is but a dashboard :-))
Summary: jit-tests no longer run on TBPL → jit-tests no longer run as part of make check on buildbot jobs
Comment 2•12 years ago
|
||
It's likely fallout from bug 784841
Comment 3•12 years ago
|
||
I don't think bug 638219 is relevant to this, but I'm afraid I don't have a good enough grasp of the tools here to make that conclusive. In any case, the recently-landed patch for bug 638219 only changed Python code that runs as part of the test harness, not the invocations of that code.
Comment 4•12 years ago
|
||
It's confirmed fallout from bug 784841: make check doesn't recurse js/src anymore because it's in tier_js_staticdirs, while it was tier_js_dirs before. And tier_*_staticdirs are not recursed for make check.
Blocks: 784841
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #4)
> It's confirmed fallout from bug 784841: make check doesn't recurse js/src
> anymore because it's in tier_js_staticdirs, while it was tier_js_dirs
> before. And tier_*_staticdirs are not recursed for make check.
Good times.
It has to be a static directory in a moz.build world because otherwise the moz.build reader will apply m-c's main config.status to the files in /js/src and the world will burn.
I hate to say it, but we may just want to one-off js/src as a check:: rule in a random Makefile.in (the root one?).
So jit-tests are not appearing anywhere on TBPL? That is pretty serious - Gregory, is this easy to fix or should we back out bug 784841?
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to David Anderson [:dvander] from comment #6)
> So jit-tests are not appearing anywhere on TBPL? That is pretty serious -
> Gregory, is this easy to fix or should we back out bug 784841?
Bug 784841 is not being backed out. I'll code up a dirty patch...
Assignee: nobody → gps
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•12 years ago
|
||
The easiest way to do it.
Attachment #720806 -
Flags: review?(mh+mozilla)
Updated•12 years ago
|
Attachment #720806 -
Flags: review?(mh+mozilla) → review+
Comment 10•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•