Closed Bug 847395 Opened 12 years ago Closed 12 years ago

New communications subdirectories break perf framework.

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: rik, Unassigned)

References

Details

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8440
355 bytes, text/html
julienw
: review+
vingtetun
: approval-gaia-v1+
Details
The new kind of contact imports that have just been added break our perf framework, probably because it's trying to launch apps that don't exist.
If it's possible, I think we should move the "import", "facebook", "gmail" and "live" directories under a common directory. Given that it's not trivial, we'll blacklist those directories for now.
Attachment #720686 - Attachment is patch: true
Attachment #720686 - Attachment mime type: text/html → text/plain
Attachment #720686 - Flags: review?(felash)
Comment on attachment 720686 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8440 r=me
Attachment #720686 - Flags: review?(felash) → review+
https://github.com/mozilla-b2g/gaia/commit/3335a36c863f8f1e45e4f289ee664fc5f4593a25
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 720686 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8440 only changes are in the perf framework
Attachment #720686 - Flags: approval-gaia-v1?(21)
Attachment #720686 - Attachment is patch: false
Attachment #720686 - Attachment mime type: text/plain → text/html
Comment on attachment 720686 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8440 a=tests
Attachment #720686 - Flags: approval-gaia-v1?(21) → approval-gaia-v1+
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x 3335a36c863f8f1e45e4f289ee664fc5f4593a25 <RESOLVE MERGE CONFLICTS> git commit
Flags: needinfo?(nobody)
v1-train: 8d182e1745f6ac57f1240171498382a82301ec31
status-b2g18: --- → fixed
blocking-b2g: --- → 1.5?
Please don't set flags you don't understand.
blocking-b2g: 1.5? → ---
Flags: needinfo?(nobody) → needinfo?
Flags: needinfo?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: