847418 - Error: Module: sdk/private-browsing/utils has no authority to load: ../deprecate d/window-utils

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Alexandre Poirot [:ochameau]]

We are facing a regression from bug 793925.
In case the xpi contains the SDK (no --strip-sdk argument given) and being run on FF 21+, we are seeing following exception:

  Error: Module: sdk/private-browsing/utils has no authority to load: ../deprecate
  d/window-utils
  sdk/private-browsing/utils 107
  Traceback (most recent call last):
    File "resource://gre/modules/NetUtil.jsm", line 140, in
      aCallback(pipe.inputStream, aStatusCode, aRequest);
    File "resource://gre/modules/commonjs/sdk/net/url.js", line 49, in
      resolve(data);
  ... huge promise stack ...

That exception happens because we are checking for manifest entries for modules shipped in firefox. That breaks because the manifest is build for the precise SDK version shipped in the xpi and not for the one shipped in firefox. So that if you build a xpi with sdk master in will fail on current nightly/aurora as SDK dependencies are different.

We have to somehow ignore the manifest when we are using SDK modules from firefox.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 831

Here is a simple workaround where we do not need to patch loader.
We can also modify cuddlefish and ignore sdk modules there,
but we would have to pass the info about "are we using firefox modules or not?" from bootstrap to cuddlefish.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1a36e16a346b852e6e9d97b6d10641e10a7c462a
Bug 847418: Do not ship with manifest entries for SDK modules.

https://github.com/mozilla/addon-sdk/commit/6f0f31839ac5111f461aabe48f2ff48a50ded206
Merge pull request #831 from ochameau/sdk-entries

Bug 847418: Do not ship with manifest entries for SDK modules. r=@gozala

Comment 3

[Alexandre Poirot [:ochameau]]

Needs to be uplifted to 1.14 in order to avoid being broken with ff21+ when not using --strip-sdk option.

Comment 4

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/3aeed3202173975a5e6d42c34997909053abb2e7
Merge pull request #831 from ochameau/sdk-entries

Bug 847418: Do not ship with manifest entries for SDK modules. r=@gozala(cherry picked from commit 6f0f31839ac5111f461aabe48f2ff48a50ded206)

Conflicts:

	test/private-browsing/windows.js

Comment 5

[[github robot]]

Commits pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1a36e16a346b852e6e9d97b6d10641e10a7c462a
Bug 847418: Do not ship with manifest entries for SDK modules.

https://github.com/mozilla/addon-sdk/commit/6f0f31839ac5111f461aabe48f2ff48a50ded206
Merge pull request #831 from ochameau/sdk-entries