Status
()
People
(Reporter: espindola, Assigned: espindola)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
1.76 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
Looking at the wine code the only other function I found that we need to poison is NtWriteFileGather.
(Assignee) | ||
Comment 1•5 years ago
|
||
Created attachment 721310 [details] [diff] [review] patch
Attachment #721310 -
Flags: review?(bgirard)
Comment 2•5 years ago
|
||
Comment on attachment 721310 [details] [diff] [review] patch Review of attachment 721310 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/build/mozPoisonWriteWin.cpp @@ +95,4 @@ > sNtDllInterceptor.Init("ntdll.dll"); > sNtDllInterceptor.AddHook("NtFlushBuffersFile", reinterpret_cast<intptr_t>(patched_FlushBuffersFile), reinterpret_cast<void**>(&gOriginalFlushBuffersFile)); > sNtDllInterceptor.AddHook("NtWriteFile", reinterpret_cast<intptr_t>(patched_WriteFile), reinterpret_cast<void**>(&gOriginalWriteFile)); > + sNtDllInterceptor.AddHook("NtWriteFileGather", reinterpret_cast<intptr_t>(patched_WriteFileGather), reinterpret_cast<void**>(&gOriginalWriteFileGather)); Can you add NtWriteFile[Gather] to http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/test/win/TestDllInterceptor.cpp#119 as well?
Attachment #721310 -
Flags: review?(bgirard) → review+
(Assignee) | ||
Comment 3•5 years ago
|
||
Try push at https://tbpl.mozilla.org/?tree=Try&rev=80580cffacad I will push to m-i it the tests are OK.
(Assignee) | ||
Comment 4•5 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=0d38f1086d81
(Assignee) | ||
Comment 5•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/356116f81c88
Comment 6•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/356116f81c88
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•