Poison NtWriteFileGather

RESOLVED FIXED in mozilla22

Status

()

Product:
Core
Component:
XPCOM
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

Version:
unspecified
Target:
mozilla22
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

patch
1.76 KB, patch
BenWa
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
Looking at the wine code the only other function I found that we need to poison is NtWriteFileGather.

Comment 2

•
5 years ago 
Comment on attachment 721310 [details] [diff] [review]
patch

Review of attachment 721310 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/build/mozPoisonWriteWin.cpp
@@ +95,4 @@
>    sNtDllInterceptor.Init("ntdll.dll");
>    sNtDllInterceptor.AddHook("NtFlushBuffersFile", reinterpret_cast<intptr_t>(patched_FlushBuffersFile), reinterpret_cast<void**>(&gOriginalFlushBuffersFile));
>    sNtDllInterceptor.AddHook("NtWriteFile", reinterpret_cast<intptr_t>(patched_WriteFile), reinterpret_cast<void**>(&gOriginalWriteFile));
> +  sNtDllInterceptor.AddHook("NtWriteFileGather", reinterpret_cast<intptr_t>(patched_WriteFileGather), reinterpret_cast<void**>(&gOriginalWriteFileGather));

Can you add NtWriteFile[Gather] to http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/test/win/TestDllInterceptor.cpp#119 as well?
Attachment #721310 - Flags: review?(bgirard) → review+
(Assignee)

Comment 3

•
5 years ago 
Try push at
https://tbpl.mozilla.org/?tree=Try&rev=80580cffacad

I will push to m-i it the tests are OK.

Comment 6

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/356116f81c88
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.