Closed Bug 847468 Opened 8 years ago Closed 8 years ago

Poison NtWriteFileGather

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file)

Looking at the wine code the only other function I found that we need to poison is NtWriteFileGather.
Comment on attachment 721310 [details] [diff] [review]
patch

Review of attachment 721310 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/build/mozPoisonWriteWin.cpp
@@ +95,4 @@
>    sNtDllInterceptor.Init("ntdll.dll");
>    sNtDllInterceptor.AddHook("NtFlushBuffersFile", reinterpret_cast<intptr_t>(patched_FlushBuffersFile), reinterpret_cast<void**>(&gOriginalFlushBuffersFile));
>    sNtDllInterceptor.AddHook("NtWriteFile", reinterpret_cast<intptr_t>(patched_WriteFile), reinterpret_cast<void**>(&gOriginalWriteFile));
> +  sNtDllInterceptor.AddHook("NtWriteFileGather", reinterpret_cast<intptr_t>(patched_WriteFileGather), reinterpret_cast<void**>(&gOriginalWriteFileGather));

Can you add NtWriteFile[Gather] to http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/test/win/TestDllInterceptor.cpp#119 as well?
Attachment #721310 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/356116f81c88
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.