847468 - Poison NtWriteFileGather

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Looking at the wine code the only other function I found that we need to poison is NtWriteFileGather.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 721310 [details] [diff] [review]
patch

Review of attachment 721310 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/build/mozPoisonWriteWin.cpp
@@ +95,4 @@
>    sNtDllInterceptor.Init("ntdll.dll");
>    sNtDllInterceptor.AddHook("NtFlushBuffersFile", reinterpret_cast<intptr_t>(patched_FlushBuffersFile), reinterpret_cast<void**>(&gOriginalFlushBuffersFile));
>    sNtDllInterceptor.AddHook("NtWriteFile", reinterpret_cast<intptr_t>(patched_WriteFile), reinterpret_cast<void**>(&gOriginalWriteFile));
> +  sNtDllInterceptor.AddHook("NtWriteFileGather", reinterpret_cast<intptr_t>(patched_WriteFileGather), reinterpret_cast<void**>(&gOriginalWriteFileGather));

Can you add NtWriteFile[Gather] to http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/test/win/TestDllInterceptor.cpp#119 as well?

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Try push at
https://tbpl.mozilla.org/?tree=Try&rev=80580cffacad

I will push to m-i it the tests are OK.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

 https://tbpl.mozilla.org/?tree=Try&rev=0d38f1086d81

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/356116f81c88

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/356116f81c88