If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

A typo in metro/base/tests/Makefile.in

RESOLVED FIXED

Status

Firefox for Metro
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: raymondlee, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
There is a typo in a makefile which causes an error when building metro.

http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/tests/Makefile.in#34
(Reporter)

Comment 1

5 years ago
Created attachment 720821 [details] [diff] [review]
v1
Attachment #720821 - Flags: review?(mbrubeck)
(Reporter)

Comment 2

5 years ago
(In reply to Raymond Lee [:raymondlee] from comment #1)
> Created attachment 720821 [details] [diff] [review]
> v1

Building metro is fine after applying this patch
(Reporter)

Updated

5 years ago
OS: All → Mac OS X

Updated

5 years ago
Blocks: 841214
Comment on attachment 720821 [details] [diff] [review]
v1

Review of attachment 720821 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this on Windows too just to make sure it doesn't break anything.
Attachment #720821 - Flags: review?(mbrubeck) → review+
(Reporter)

Comment 4

5 years ago
Created attachment 721038 [details] [diff] [review]
Patch for check-in
Attachment #720821 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ccaf14cac77
Keywords: checkin-needed
(Reporter)

Updated

5 years ago
Blocks: 847807
https://hg.mozilla.org/mozilla-central/rev/0ccaf14cac77
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
No longer blocks: 841214
You need to log in before you can comment on or make changes to this bug.