847527 - A typo in metro/base/tests/Makefile.in

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Build Config, defect)

Description

[Raymond Lee [:raymondlee]]

There is a typo in a makefile which causes an error when building metro.

http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/tests/Makefile.in#34

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #1)
> Created attachment 720821 [details] [diff] [review]
> v1

Building metro is fine after applying this patch

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 720821 [details] [diff] [review]
v1

Review of attachment 720821 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this on Windows too just to make sure it doesn't break anything.

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ccaf14cac77

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ccaf14cac77