Closed Bug 847527 Opened 7 years ago Closed 7 years ago

A typo in metro/base/tests/Makefile.in

Categories

(Firefox for Metro Graveyard :: Build Config, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: raymondlee, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

There is a typo in a makefile which causes an error when building metro.

http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/tests/Makefile.in#34
Attached patch v1 (obsolete) — Splinter Review
Attachment #720821 - Flags: review?(mbrubeck)
(In reply to Raymond Lee [:raymondlee] from comment #1)
> Created attachment 720821 [details] [diff] [review]
> v1

Building metro is fine after applying this patch
OS: All → Mac OS X
Comment on attachment 720821 [details] [diff] [review]
v1

Review of attachment 720821 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this on Windows too just to make sure it doesn't break anything.
Attachment #720821 - Flags: review?(mbrubeck) → review+
Attachment #720821 - Attachment is obsolete: true
Keywords: checkin-needed
Blocks: 847807
https://hg.mozilla.org/mozilla-central/rev/0ccaf14cac77
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
No longer blocks: metrov1triage
You need to log in before you can comment on or make changes to this bug.