847578 - [Holo] Flat UI for Doorhangers

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Currently doorhangers are shown in a dark background with shadows. The button bar changes with the phone and doesn't look good with Holo theme. It would be nice to have doorhangers and site identity popups use a lighter theme: http://cl.ly/image/0H1S113Y0Q0z

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Doorhangers

This removes all blacks (yay!) and uses popup-backgrounds similar to custom menu. The phone ones have to be edge-to-edge, while the tablet ones are smaller. Hence two versions are used (PopupWindow cannot go past screen boundaries :( ). Removed the resources that aren't needed.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Doorhanger buttons

Buttons were using button-bar style. This is removed, and a new style is provided by inflating the button from the XML. The background is same as the content portion. An optional divider is shown, if buttons are visible.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 3: Dividers

This patch adds dividers between buttons. Also, dividers (orange! yaay!) between doorhangers. Basically the orange divider is part of the individual doorhanger. They are shown/hidden based on the list that is about to be shown (last one's divider is hidden).

(The other approach could be to use a DoorHangerAdapter and show a list view. But things would get more complex in that approach).

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 4: Larry

No more shadows for Larry! (But who named him larry, btw?)
The UI is flat (one section of text, image on the right top).

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 5: Remove views

There are so many text-views in SiteIdentity popup. Removed some of them.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 720895 [details] [diff] [review]
Part 2: Doorhanger buttons

Let's double check with Ian on the colors

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 720898 [details] [diff] [review]
Part 3: Dividers

fixDoorHangerDividers -> showDividers

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 720899 [details] [diff] [review]
Part 4: Larry

Again, let's double check with Ian on the larry color changes

Comment 9

[Sriram Ramasubramanian [:sriram]]

Trying: https://tbpl.mozilla.org/?tree=Try&rev=d49c88c49c4c

Comment 10

[Sriram Ramasubramanian [:sriram]]

Trying: https://tbpl.mozilla.org/?tree=Try&rev=0b159b207f4d

Comment 11

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60e2ba8bd317
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d314396301
https://hg.mozilla.org/integration/mozilla-inbound/rev/7759f17f1e3c
https://hg.mozilla.org/integration/mozilla-inbound/rev/eaf1992eb793
https://hg.mozilla.org/integration/mozilla-inbound/rev/a526847e4f90

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60e2ba8bd317
https://hg.mozilla.org/mozilla-central/rev/a8d314396301
https://hg.mozilla.org/mozilla-central/rev/7759f17f1e3c
https://hg.mozilla.org/mozilla-central/rev/eaf1992eb793
https://hg.mozilla.org/mozilla-central/rev/a526847e4f90