Closed Bug 847728 Opened 11 years ago Closed 11 years ago

Intermittent SM rootanalysis TEST-UNEXPECTED-FAIL | jit_test.py | tests/jaeger/bug738525.js, tests/basic/testPaths.js: Assertion failure: !js::IsPoisonedPtr(l), at js/HashTable.h:489

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: RyanVM, Assigned: terrence)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

backtrace
3.78 KB, text/plain
Details
v0
5.50 KB, patch
sfink
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=20314516&tree=Mozilla-Inbound

Linux x86-64 mozilla-inbound leak test spidermonkey_mozilla-inbound-rootanalysis build on 2013-03-04 14:37:20 PST for push 6af9594ac0d4
slave: bld-linux64-ec2-347

FAIL - /builds/slave/m-in_l64-d_sm-rootanalysis-000/src/js/src/jit-test/tests/jaeger/bug738525.js
TEST-UNEXPECTED-FAIL | jit_test.py --no-ion --no-jm --no-ti| /builds/slave/m-in_l64-d_sm-rootanalysis-000/src/js/src/jit-test/tests/jaeger/bug738525.js: Assertion failure: !js::IsPoisonedPtr(l), at /builds/slave/m-in_l64-d_sm-rootanalysis-000/objdir/dist/include/js/HashTable.h:489
https://tbpl.mozilla.org/php/getParsedLog.php?id=20436867&tree=Mozilla-Inbound
Summary: Intermittent SM rootanalysis TEST-UNEXPECTED-FAIL | jit_test.py --no-ion --no-jm --no-ti| tests/jaeger/bug738525.js: Assertion failure: !js::IsPoisonedPtr(l), at /builds/slave/m-in_l64-d_sm-rootanalysis-000/objdir/dist/include/js/HashTable.h:489 → Intermittent SM rootanalysis TEST-UNEXPECTED-FAIL | jit_test.py | tests/jaeger/bug738525.js: Assertion failure: !js::IsPoisonedPtr(l), at js/HashTable.h:489
Blocks: ExactRooting
https://tbpl.mozilla.org/php/getParsedLog.php?id=21034409&tree=Mozilla-Inbound
Summary: Intermittent SM rootanalysis TEST-UNEXPECTED-FAIL | jit_test.py | tests/jaeger/bug738525.js: Assertion failure: !js::IsPoisonedPtr(l), at js/HashTable.h:489 → Intermittent SM rootanalysis TEST-UNEXPECTED-FAIL | jit_test.py | tests/jaeger/bug738525.js, tests/basic/testPaths.js: Assertion failure: !js::IsPoisonedPtr(l), at js/HashTable.h:489
Attached file backtrace — 
I managed to collect a core from this error. Here is the backtrace.
Attached patch v0 — — Splinter Review 
With the patch from Bug 852802 this reproduces for me about 1 in 50 runs, so I was able to verify success by running ~200 times without failure.

I'm guessing this is a weird compilation bug: as far as I can tell there are zero rooting failures in the existing code. The crash failure went away when I removed the intermediate IdStringifier class: perhaps the nesting was confusing g++. The extra Handle additions and removal of the manual rooting are just cleanups that I'm throwing in because I was in the area.
Assignee: general → terrence
Status: NEW → ASSIGNED
Attachment #731404 - Flags: review?(sphink)
Comment on attachment 731404 [details] [diff] [review]
v0

Review of attachment 731404 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me. I still don't really understand why it was intermittent, though.

At any rate, it's good to see the JS_AddNamedStringRoot go away.
Attachment #731404 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/f12e720612a5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: