847779 - Videos with MPEG2 audio not supported

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Diego Wilson [:diego]]

Attachment: MPEG4 video with MPEG2 audio

OMX hardware decoders do not support this.

I spoke to cjones and he suggested actively rejecting this format before even attempting to decode if possible.

Sample attached

Comment 1

[Diego Wilson [:diego]]

Attachment: Abort playback if OMX audio init fails

Otherwise the OMX decoder is never released during thumbnail generation. And, for example, a video with an unsupported audio format would block all further OMX playback.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 733384 [details] [diff] [review]
Abort playback if OMX audio init fails

Review of attachment 733384 [details] [diff] [review]:
-----------------------------------------------------------------

Reader changes are sensible, I'm not sure about the OmxDecoder change, doublec would know about that.

Comment 3

[cajbir (:cajbir)]

Comment on attachment 733384 [details] [diff] [review]
Abort playback if OMX audio init fails

Review of attachment 733384 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/omx/MediaOmxReader.cpp
@@ +51,5 @@
>    *aTags = nullptr;
>  
>    if (!mOmxDecoder.get()) {
>      mOmxDecoder = new OmxDecoder(mDecoder->GetResource(), mDecoder);
> +    if(!mOmxDecoder->Init()) {

Needs a space between "if" and "(" per style rules.

Comment 4

[Diego Wilson [:diego]]

Attachment: Abort playback if OMX audio init fails v2

Addressed format nit
Carry forward r+

Comment 5

[Michael Vines [:m1] [:evilmachines]]

(leo+ as this a downstream request, with a r+ patch in hand that simply improves error handling)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca8b7c325ede

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca8b7c325ede

Comment 8

[Diego Wilson [:diego]]

Can I get help landing on gecko b2g18 ?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Absolutely. Bugs filed under the Gaia component typically don't get on my radar, so adding a checkin-needed is a good way to get my attention (or needinfo works :)...). Otherwise, I do periodically go through the Gaia tef+ bugs too to look for bugs like these, but it's not an every day thing for me.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/d2d8ae22d88a