Closed Bug 847779 Opened 7 years ago Closed 7 years ago

Videos with MPEG2 audio not supported

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:leo+, firefox21 wontfix, firefox22 wontfix, firefox23 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)

RESOLVED FIXED
B2G C4 (2jan on)
blocking-b2g leo+
Tracking Status
firefox21 --- wontfix
firefox22 --- wontfix
firefox23 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: diego, Assigned: diego)

References

()

Details

(Whiteboard: [SR 01088871] [TD-8903])

Attachments

(2 files, 1 obsolete file)

OMX hardware decoders do not support this.

I spoke to cjones and he suggested actively rejecting this format before even attempting to decode if possible.

Sample attached
Otherwise the OMX decoder is never released during thumbnail generation. And, for example, a video with an unsupported audio format would block all further OMX playback.
Attachment #733384 - Flags: review?(cpearce)
Attachment #733384 - Flags: review?(chris.double)
Comment on attachment 733384 [details] [diff] [review]
Abort playback if OMX audio init fails

Review of attachment 733384 [details] [diff] [review]:
-----------------------------------------------------------------

Reader changes are sensible, I'm not sure about the OmxDecoder change, doublec would know about that.
Attachment #733384 - Flags: review?(cpearce) → review+
Comment on attachment 733384 [details] [diff] [review]
Abort playback if OMX audio init fails

Review of attachment 733384 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/omx/MediaOmxReader.cpp
@@ +51,5 @@
>    *aTags = nullptr;
>  
>    if (!mOmxDecoder.get()) {
>      mOmxDecoder = new OmxDecoder(mDecoder->GetResource(), mDecoder);
> +    if(!mOmxDecoder->Init()) {

Needs a space between "if" and "(" per style rules.
Attachment #733384 - Flags: review?(chris.double) → review+
Assignee: nobody → dwilson
Addressed format nit
Carry forward r+
Attachment #733384 - Attachment is obsolete: true
Attachment #733587 - Flags: review+
blocking-b2g: --- → leo?
Keywords: checkin-needed
(leo+ as this a downstream request, with a r+ patch in hand that simply improves error handling)
blocking-b2g: leo? → leo+
Whiteboard: [SR 01088871]
Attachment #733587 - Attachment is patch: true
https://hg.mozilla.org/mozilla-central/rev/ca8b7c325ede
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → B2G C4 (2jan on)
Can I get help landing on gecko b2g18 ?
Flags: needinfo?(ryanvm)
Absolutely. Bugs filed under the Gaia component typically don't get on my radar, so adding a checkin-needed is a good way to get my attention (or needinfo works :)...). Otherwise, I do periodically go through the Gaia tef+ bugs too to look for bugs like these, but it's not an every day thing for me.
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Component: Gaia::Video → General
Whiteboard: [SR 01088871] → [SR 01088871] [TD-8903]
Flags: in-moztrap?
Flags: in-moztrap? → in-moztrap+
You need to log in before you can comment on or make changes to this bug.