Update template for unit tests to correct (current) usage of require() statements

RESOLVED FIXED in 1.14

Status

Add-on SDK
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: KWierso, Assigned: KWierso)

Tracking

unspecified
1.14
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The template for test-main.js is still require()ing main.js, instead of ./main.js, and is also require()ing test, instead of sdk/test.
(Assignee)

Updated

5 years ago
Assignee: nobody → kwierso
OS: Windows 8 → All
Hardware: x86_64 → All
(Assignee)

Comment 1

5 years ago
Created attachment 721104 [details]
Pointer to pull request 832
Attachment #721104 - Flags: review?(rFobic)
Comment on attachment 721104 [details]
Pointer to pull request 832

Thanks wes for identifying/fixing that!
I thought that we had tests against cfx init?
I'll try to provide one.
Attachment #721104 - Flags: review?(rFobic) → review+

Comment 3

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d81cb8e3d4fa5556eaed2c5640a232d78440dfad
Bug 847785 - Update template for unit tests to the current require() usage statements

https://github.com/mozilla/addon-sdk/commit/b0f21bbb646e6e9f2185a467cdec14a7fc73754b
Merge pull request #832 from KWierso/bug847785

Bug 847785 - Update template for unit tests to the current require() usage statements r=@ochameau
Blocks: 847833
I'd imagine we would like to push this to 1.14 to have a working cfx init?
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.14
+1 for cherry-picking!

Comment 6

5 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/168455f6df1b49da27926b6e49a57f9647c6dd48
Merge pull request #832 from KWierso/bug847785

Bug 847785 - Update template for unit tests to the current require() usage statements r=@ochameau(cherry picked from commit b0f21bbb646e6e9f2185a467cdec14a7fc73754b)
Blocks: 852338
You need to log in before you can comment on or make changes to this bug.