847817 - [Cost Control]Wrong position of the cursor while selecting the numeric input for Data Usage limit

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Leo]

Attachment: Screen shot attached

1. Title : Wrong position of the cursor while selecting the numeric input for Data Usage limit.
2. Precondition : 
3. Tester's Action :    Usage -> Welcome_Next -> Next -> Data use alert on ->Alert me when used 1GB_Touch -> Number input mode     
4. Detailed Symptom (ENG.) : Due to wrong position of the cursor,the input numbers are entered are displayed wrongly.
5. GAIA version : 6916e18d1f72936e892543cf4a104a7d457f78ad
6. Expected : The cursor position should be after the '1' GB.So that user need not to click one more time to get the cursor position after the '1'GB.
7.Reproducibility: Y
1)Frequency Rate : 100%
8.Comparison Results : 
1)Model Comparing : 
9. Attached files: 2013-03-18-02-50-27.png
1)Log : 
2)Test Contents : 
3)Video file :

Comment 1

[Leo]

Attachment: Pointer to Pull Request https://github.com/mozilla-b2g/gaia/pull/8508

Please review the patch at pull request
https://github.com/mozilla-b2g/gaia/pull/8508

Comment 2

[Salvador de la Puente González [:salva]]

I'm not sure about the solution. I like it. Now, every time you want to add numbers is OK but if you want to change from 250 to 200, you are not able to change the position of the cursor by clicking in the middle of 5 and 0. Let's check Marco about interaction before r+.

Comment 3

[Leo]

Every time the cursor will be at the end of the number.
After that i can able to put the cursor in the middle or at any position of the number and able to modify it.

Comment 4

[Salvador de la Puente González [:salva]]

(In reply to leo.bugzilla.gaia from comment #3)
> Every time the cursor will be at the end of the number.

Every time you click, I understand.

> After that i can able to put the cursor in the middle or at any position of
> the number and able to modify it.

How? we have no cursor keys to move the position. We can only change the cursor position by clicking in the position you want, but this will trigge the former event.

Comment 5

[Leo]

Yes your right.Please find the below test scenario.

step1: Default datalimit is '1'GB and the cursor is at left side of '1'GB.
step2: Enter zeros at the cursor position and click done.(Ex:00001 GB)
step3: Again open,then the cursor is at right side of '1'GB.

In step2 we cant delete the '1'(by pressing the backspace key) without moving the cursor position.
In step3 we can delete the '1' by pressing the backspace button.(Because cursor is at right side)

Comment 6

[Salvador de la Puente González [:salva]]

So, the second time the user is well positioned. Then I suggest you to position the cursor not when clicked but only after gaining focus. Then we always place the cursor properly. What do you think about this?

Comment 7

[Leo]

After setting the focus for input field i am calling setSelectionRange().Is it not a proper place?

The cursor is well positioned only in case of step 2.(Ex:00001 GB)
After that,close the app and reopen it,again cursor moves to left side of the given number.
So it feels user,the cursor position is not proper for first time.

So always keeping the cursor at the end is better,so the user can use all keys.(backspace also)

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 722047 [details]
Pointer to Pull Request https://github.com/mozilla-b2g/gaia/pull/8508

I'm ver sorry, I don't know what I was trying to do. Forgive me ;) Your solution is OK.

Comment 9

[Salvador de la Puente González [:salva]]

Anyway, you have a non-blocking nit in GitHub, please, fix it before landing. Thanks.

Comment 10

[Leo]

I fixed the non-blocking nit in the patch.(Added space between the parameters)
Please review.

Comment 11

[Salvador de la Puente González [:salva]]

Master: 4ce2203b37be7c94aeb3602f9af76b0815ad037a

Do not worry, you already had my r+. ;)

Comment 12

[Salvador de la Puente González [:salva]]

Comment on attachment 722047 [details]
Pointer to Pull Request https://github.com/mozilla-b2g/gaia/pull/8508

Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 722047 [details]
Pointer to Pull Request https://github.com/mozilla-b2g/gaia/pull/8508

Approving for uplift since this is low risk and fixes severe user annoyance when editing input.

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 4ce2203b37be7c94aeb3602f9af76b0815ad037a as:
v1-train: 49f3fb96186efd8583fd6214ea9666a785ec6060

Comment 15

[Frederik Braun [:freddy]]

Once the dialog opens, the input field is not focused automatically. I have to tap the input manually and usually make the focus go somewhere else than the end.
It is exceptionally hard moving the cursor position back to the end of the input field making it quite annoying to change the last digit and enter the desired data limit.

Do you want another bug for this or should we reopen this one?

Comment 16

[Salvador de la Puente González [:salva]]

Please, file another bug and assign it to :mai
Thanks!

Comment 17

[Frederik Braun [:freddy]]

Filed as bug 1015167. Thanks!