847839 - Remove obsolete files for Android XUL Fennec: embedding/android/ and mobile/xul/

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: remove-xul-android.patch

I think there are other files in the embedding/ directory that are not used by any other products, but I'll let someone else weed those out. :) AFAICT, the only embedding/ files used by Metro are the embedding/components/webbrowserpresist/.

Here is try build that is green for all platforms except B2G:

https://tbpl.mozilla.org/?tree=Try&rev=4eb7a735e6c7

The B2G break do not look related to my changes. Here is a try build from the same mozilla-inbound revision without my patch. B2G is still red:

https://tbpl.mozilla.org/?tree=Try&rev=e69721092a54

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 721143 [details] [diff] [review]
remove-xul-android.patch

After a quick look, this seems fine. We do want to move the "VideoPlayer" parts to /mobile/android/base. We used that in XUL fennec to act as a fallback "youtube" video player for platformas without the real Youtube player: Amazon Kindle and Cyanogemod.

Can you make a patch to port it over to mobile/android ?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

We have bug 844414 for that.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: part-1-port-xul-videoplayer.patch

f? This patch moves the XUL VideoPlayer.java into mobile/android. Unfortunately, this code DOES NOT work as-is.

I'd like to land this code, but disable it. This code does not affect devices that have an official YouTube app and leaves devices like the Kindle Fire without a YouTube app no worse for the wear. If we decide to support the Kindle Fire, we can debug the YouTube URL problem then. <:)

When we ask YouTube for a manifest of a video's available formats, the manifest's video URLs return HTTP 403 Forbidden. Requesting the same manifest on the desktop browser returns different video URLs. If I substitute the desktop manifest's video URLs on Android, the videos play correctly in the XUL VideoPlayer. YouTube returns the same forbidden URLs on Android even if I use the desktop browser's User-Agent on Wi-Fi.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 722406 [details] [diff] [review]
part-1-port-xul-videoplayer.patch

I agree with landing this and debugging the URL issue later.

Comment 5

[Chris Peterson [:cpeterson]]

I need to determine whether we support H.264 or Flash on the Kindle Fire. If we do, then the YouTube desktop website should work and this YouTube app problem should only affect the m.youtube.com mobile website.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Remove some more XUL fennec entrails from widget/android

I found some more XUL code to remove and was too lazy to file a new bug so I'm throwing it here :)

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 722722 [details] [diff] [review]
Remove some more XUL fennec entrails from widget/android

Review of attachment 722722 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! \o/

Comment 8

[Chris Peterson [:cpeterson]]

Attachment: part-1a-port-xul-videoplayer.patch

This patch ports VideoPlayer.java from embedding/android/ to mobile/android/. As noted in the above comments, IT DOES NOT WORK but it is not expected to be invoked. This patch is mostly to just keep hang onto this code until needed.

Comment 9

[Chris Peterson [:cpeterson]]

Attachment: part-1b-videoplayer-style-cleanups.patch

Clean up VideoPlayer.java style nits.

Comment 10

[Chris Peterson [:cpeterson]]

Attachment: part-2-remove-xul-fennec.patch

rm -r embedding/android/

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 726368 [details] [diff] [review]
part-2-remove-xul-fennec.patch

LGTM

Comment 12

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f93de36b3bc
https://hg.mozilla.org/integration/mozilla-inbound/rev/a93c2f4828ae
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b8e128a989c

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8f93de36b3bc
https://hg.mozilla.org/mozilla-central/rev/a93c2f4828ae
https://hg.mozilla.org/mozilla-central/rev/6b8e128a989c

Comment 14

[Kartikaya Gupta (email:[e-mail])]

I never actually landed attachment 722722 [details] [diff] [review] under the assumption that you would.. but I should have made that clearer. Landed now, marking bug reopened so it will get closed again (properly) once it is merged to central.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb0aff9c9129

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cb0aff9c9129