Closed
Bug 847870
Opened 11 years ago
Closed 11 years ago
Call nsIDocShell.gatherCharsetMenuTelemetry() when the user makes a selection from the character encoding menu
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
In order to collect telemetry about the necessity of the character encoding menu feature, Firefox for Android should call nsIDocShell.gatherCharsetMenuTelemetry() whenever it assigns to nsIDocShell.charset as a result of the user choosing a character encoding from the character encoding menu.
|
Assignee | |
Comment 1•11 years ago
|
||
Relevant piece of source: https://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#6737
|
|
Assignee | |
Comment 2•11 years ago
|
||
(nsIDocCharset is obsolete, so getting rid of the QI.)
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
|
||
Comment 3•11 years ago
|
||
Comment on attachment 721589 [details] [diff] [review] Call the telemetry gathering method Looks OK to me
Attachment #721589 -
Flags: review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Thanks. Landed. https://hg.mozilla.org/integration/mozilla-inbound/rev/559eed4cdd0b
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/559eed4cdd0b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•