Closed Bug 847964 Opened 8 years ago Closed 8 years ago

Rename &noignore=1 to &showall=1 (with support for the legacy format)

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Makes my eyes bleed less & may even (haha) reduce the stigma of a "hidden/ignored" job type.
Attached patch Patch v1Splinter Review
* s/noignore/showall/
* s/noIgnore/showAll/
* Adds a block to _parseParams() in Controller.js that maps the legacy format to the new one (ie: old URLs will still work, but will display the new parameter name in the address bar). See the block above it for how the existing code works with replacing &branch=buildbot_foo with &tree=foo (I didn't even know TBPL supported this!).
Attachment #721290 - Flags: review?(ryanvm)
Summary: Rename &noignore=1 to &showall=1 → Rename &noignore=1 to &showall=1 (with support for the legacy format)
Attachment #721290 - Flags: review?(ryanvm) → review+
Depends on: 849194
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.