Closed
Bug 847964
Opened 12 years ago
Closed 12 years ago
Rename &noignore=1 to &showall=1 (with support for the legacy format)
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
6.00 KB,
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
Makes my eyes bleed less & may even (haha) reduce the stigma of a "hidden/ignored" job type.
|
Assignee | |
Comment 1•12 years ago
|
||
* s/noignore/showall/
* s/noIgnore/showAll/
* Adds a block to _parseParams() in Controller.js that maps the legacy format to the new one (ie: old URLs will still work, but will display the new parameter name in the address bar). See the block above it for how the existing code works with replacing &branch=buildbot_foo with &tree=foo (I didn't even know TBPL supported this!).
Attachment #721290 -
Flags: review?(ryanvm)
|
|
Assignee | |
Updated•12 years ago
|
Summary: Rename &noignore=1 to &showall=1 → Rename &noignore=1 to &showall=1 (with support for the legacy format)
|
||
Updated•12 years ago
|
Attachment #721290 -
Flags: review?(ryanvm) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Comment 3•12 years ago
|
||
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•