Closed
Bug 848088
Opened 12 years ago
Closed 12 years ago
IonMonkey: property get IC for DOM list proxies fails to detect expando
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(2 files, 1 obsolete file)
|
982 bytes,
text/html
|
Details | |
|
5.97 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
The code was mostly copied from the JM IC but it uses |if (expando && expando->nativeLookup(cx, name))| to detect that the expando object doesn't contain a name whereas the JM one uses |if (expando && expando->nativeLookup(cx, name) == NULL)|.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → peterv
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #721420 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Attachment #726061 -
Flags: review?(jdemooij)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 726061 [details] [diff] [review]
v1.1
Review of attachment 726061 [details] [diff] [review]:
-----------------------------------------------------------------
Nice, thanks for fixing this.
Attachment #726061 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•