Closed Bug 848088 Opened 8 years ago Closed 8 years ago

IonMonkey: property get IC for DOM list proxies fails to detect expando

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(2 files, 1 obsolete file)

Testcase
982 bytes, text/html
Details
v1.1
5.97 KB, patch
jandem
: review+
Details | Diff | Splinter Review
Attached file Testcase — 
The code was mostly copied from the JM IC but it uses |if (expando && expando->nativeLookup(cx, name))| to detect that the expando object doesn't contain a name whereas the JM one uses |if (expando && expando->nativeLookup(cx, name) == NULL)|.
Attached patch v1 (obsolete) — — Splinter Review
Assignee: nobody → peterv
Status: NEW → ASSIGNED
Attached patch v1.1 — — Splinter Review
Attachment #721420 - Attachment is obsolete: true
Blocks: 852092
Attachment #726061 - Flags: review?(jdemooij)
Comment on attachment 726061 [details] [diff] [review]
v1.1

Review of attachment 726061 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks for fixing this.
Attachment #726061 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/92278dbb6657
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Depends on: 942477
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.