848233 - [Gaia][Contacts] Use new WebAPI to get SIM contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 847741 we're going to move the mozContacts.getSimContacts to mozMobileConnection.icc (nsIDOMIccManager), so this bug is filed in Gaia side to make the corresponding change.

Comment 1

[Jose Manuel Cantera]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #0)
> In Bug 847741 we're going to move the mozContacts.getSimContacts to
> mozMobileConnection.icc (nsIDOMIccManager), so this bug is filed in Gaia
> side to make the corresponding change.

please update this, once the platform side of this bug is up and running.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I'll let you know when Bug 847741 is r+ and sr+,
hope we could commit into gecko and gaia at the same time.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Jose M.
Bug 847741 is already r+ and sr+, 
can you help to prepare Gaia side modification?

Or if you're not available,
It seems Gaia change is only a few lines,
I could do this.

Thank you.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

ping? Jose M. Cantera 
Sorry I don't know your irc name.

Comment 5

[Jose Manuel Cantera]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #4)
> ping? Jose M. Cantera 
> Sorry I don't know your irc name.

feel free to submit a Gaia patch and add me as a reviewer

thanks!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

I guess this work is not part of 1.1 isnt?

Thx!

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Francisco Jordano [:arcturus] from comment #6)
> I guess this work is not part of 1.1 isnt?

No, it isn't in 1.1.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: [Pull Request]

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: [Pull Request]

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 744989 [details]
[Pull Request]

Hi, Jose
Can you review this patch for me?

thanks

Comment 11

[Jose Manuel Cantera]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #7)
> (In reply to Francisco Jordano [:arcturus] from comment #6)
> > I guess this work is not part of 1.1 isnt?
> 
> No, it isn't in 1.1.

the patch would only work with MozCentral, right?

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Jose M. Cantera from comment #11)
> the patch would only work with MozCentral, right?

Yes,
But I haven't landed Bug 847741 yet.
If I need to land it first please let me know.

Comment 13

[Jose Manuel Cantera]

Hi Yoshi,

The code changes look trivial, but I would prefer to have the Gecko patch landed in Moz Central before adding the r+ to this patch

thanks for your help!

Comment 14

[Gregor Wagner [:gwagner]]

Stealing the review since it's already causing:
E/GeckoConsole(  948): [JavaScript Error: "TypeError: navigator.mozContacts.getSimContacts is not a function" {file: "app://communications.gaiamobile.org/contacts/js/utilities/import_sim_contacts.js" line: 54}]

Comment 15

[Gregor Wagner [:gwagner]]

https://github.com/mozilla-b2g/gaia/commit/488d82ecc92e3d6067293c90070fba00cf95900e

Comment 16

[Gregor Wagner [:gwagner]]

Hm the TypeError is gone but I get the "Could not import contacts from SIM" message :(

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I think I have tested this before sending Pull Request,
anyway I'll test it again to check this.

Thanks for the review and report this, Gregor.

Comment 18

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Gregor
I just test it and it seems working fine.

Gaia: 674fdd8a15ca582eb179310c7a2f4f474e38b645
Gecko(mercurial): changeset:   130780:69008b1fd6eb

Can you tell me what error you met?

Thanks

Comment 19

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Gregor, I still cannot reproduce the error you said,
can you help to check this?

Thanks

Comment 20

[Gregor Wagner [:gwagner]]

Hm now it works. No idea what happened.