848256 - Phonebook :: API :: When request have comma separated parameters, API does not get the data.

Status: VERIFIED FIXED

Description

[ravi]

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.56 Safari/537.17

Steps to reproduce:

1. Hit the API request with these argumetns -- https://mozillians.allizom.org/api/v1/users/?app_name=mozapp&app_key=test&groups=staff,qa

2. Observe for the response.


Actual results:

The response code was 200. The result had nothing in it.


Expected results:

Should be able to fetch the results with comma separated parameters.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Confirmed. Thanks for reporting Ravi!

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/a814dc7f4b5a7157d6514ee0ced0e2e0f5fb63d9
[fix bug 911980][fix bug 848256][fix bug 848257] API refactoring, tests and bug fixing.

* Refactor API to not use the ElasticSearch backend (bug 911980)
* Explicitly set the fields returned by UserResource
* Fix filters containing spaces (bug 848257)
* Fix filters with commas (bug 848256)
* Fix default data ordering (bug 914384)

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

The URL above shows 546 accounts, which is better than a blank screen. Furthermore, 546 is the sum of the members in the QA group (https://mozillians.allizom.org/api/v1/users/?app_name=mozapp&app_key=test&groups=qa) and the staff group (https://mozillians.allizom.org/api/v1/users/?app_name=mozapp&app_key=test&groups=staff), which suggests that the comma is doing what it's supposed to.