848281 - [HOMESCREEN] Wallpaper is not adjusted in the lock screen

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[rafael.marquez]

Attachment: wallpaper

*Procedure
1. Open Gallery app
2. Open a picture
3. Select the picture as wallpaper

*Expected Result
The picture is set succesfully as wallpaper in all screens

*Actual Result
The picture is set succesfully as wallpaper in home screen, but is not adjusted the lock screen 


Gecko-8ed37c2
Gaia-21cedfd

Comment 1

[Cristian Rodriguez (:crdlc)]

If it is not adjusted the lock screen why Product/Component: Boot2Gecko :: Gaia::Homescreen?

Comment 2

[Alex Keybl [:akeybl]]

Is this image specific? Or for all cropped lockscreen wallpapers?

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I cannot seem to reproduce this bug as written.

I tried :
- with taking a picture and then placing as wallpaper
- with placing a picture onto the device and wallpaper
- with png, jpg formats
- with editing and then setting as wall paper.
- with v1.1 and 1.0.1
- tried with other ways of setting wallpaper ran into bug 853089

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/778da49486f0
Gaia   6c3767c2dea43b5e9aff7d156d36d69649005621
BuildID 20130320070206
Version 18.0

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e74dafa6b2d9
Gaia   1438da6ca0e020a8df686e2100a668370dfe6fb6
BuildID 20130312230202
Version 18.0

rafael, can you give more details please?

Comment 4

[Dylan Oliver [:doliver]]

Attachment: original image

triage: leo+

I see the same problem with a landscape oriented image that I saved from the browser. Attaching the file here. It gets stretched to fit the lockscreen and cropped to fit the homescreen.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

This issue is resulted from the patch of bug 829075. The patch was only landed in master so this issue does not occur in v1-train. Set to leo?

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/8761

Yuren, could you help review the change? Thanks!

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

We need to confirm if this is occurring on v1.1 and/or v1.0.1 - can someone try with the attached image and confirm so we get this landed where needed?

Comment 8

[Tony Chung [:tchung]]

Attachment: screenshot of home and lockscreen

i cant seem to get the test image from above to not crop immediately when applying to wallpaper.   screenshot shows its consistent for me on both screens.

WFM on v1.0.1.

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/5aacf880400b
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
BuildID 20130322070202
Version 18.0

Comment 9

[Dylan Oliver [:doliver]]

Arthur is correct in comment #5, my report was based on a master build (sorry). WFM on v1-train.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks yuren! 

master: https://github.com/mozilla-b2g/gaia/commit/bf9b40fbf6467a5911500d6dc1bb9e2a4f22d3c2

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Marking fixed on v1.1 in that case.

Comment 12

[Angela Hubenya]

I just tested this issue on the master build: 20130325105600 and the issue is not happening anymore. I tested using the landscape pictures, as well as portrait. Changing status to Verified as Fixed.