848339 - Remove the vestigial boolean outparam from nsWrapperCache::WrapObject

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

After bug 841289, it will no longer be used.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=94db507fb565

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Add more MOZ_OVERRIDEs

I'll fold this patch on landing.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Additional patch

This patch bitrots very fast...

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Additional patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 723057 [details] [diff] [review]
Add more MOZ_OVERRIDEs

r=me

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 723201 [details] [diff] [review]
Additional patch

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 723055 [details] [diff] [review]
patch

>+++ b/js/xpconnect/src/XPCConvert.cpp
>-                if (!flat && triedToWrap)
>-                    return false;

I think that needs to be more like:

  if (!flat && JS_IsExceptionPending(lccx.GetJSContext()) {
    return false;
  }

otherwise we might end up trying to create XPConnect wrappers for cases when wrapping threw.

You're going to need to fix SVGFETileElement as well (presumably that change just landed or something).

r=me with those fixed.

When merging, watch out for http://hg.mozilla.org/integration/mozilla-inbound/rev/cbacce36ee58 giving you conflicts.  :(

Comment 8

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43128c241d3e

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43128c241d3e