Closed Bug 848339 Opened 7 years ago Closed 7 years ago

Remove the vestigial boolean outparam from nsWrapperCache::WrapObject

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

After bug 841289, it will no longer be used.
Blocks: ParisBindings
No longer blocks: 841289
Depends on: 841289
Attached patch patchSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=94db507fb565
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #723055 - Flags: review?(bzbarsky)
I'll fold this patch on landing.
Attachment #723057 - Flags: review?(bzbarsky)
Attached patch Additional patch (obsolete) — Splinter Review
This patch bitrots very fast...
Attachment #723177 - Flags: review?(bzbarsky)
Attached patch Additional patchSplinter Review
Attachment #723177 - Attachment is obsolete: true
Attachment #723177 - Flags: review?(bzbarsky)
Attachment #723201 - Flags: review?(bzbarsky)
Comment on attachment 723057 [details] [diff] [review]
Add more MOZ_OVERRIDEs

r=me
Attachment #723057 - Flags: review?(bzbarsky) → review+
Comment on attachment 723201 [details] [diff] [review]
Additional patch

r=me
Attachment #723201 - Flags: review?(bzbarsky) → review+
Comment on attachment 723055 [details] [diff] [review]
patch

>+++ b/js/xpconnect/src/XPCConvert.cpp
>-                if (!flat && triedToWrap)
>-                    return false;

I think that needs to be more like:

  if (!flat && JS_IsExceptionPending(lccx.GetJSContext()) {
    return false;
  }

otherwise we might end up trying to create XPConnect wrappers for cases when wrapping threw.

You're going to need to fix SVGFETileElement as well (presumably that change just landed or something).

r=me with those fixed.

When merging, watch out for http://hg.mozilla.org/integration/mozilla-inbound/rev/cbacce36ee58 giving you conflicts.  :(
Attachment #723055 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/43128c241d3e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Depends on: 851392
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.